AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080724150326.223e61f3@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9751@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 24 Jul 2008 15:03:55 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review change 30173
Message-ID: <20080724150355.39d1affb@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9751@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9751@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 24 Jul 2008 14:29:32 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Rendell,
>     Andy is out and I don't know how fast he can respond to this
> review request. Please review this change.
> 
> It is on my workspace on linux-compile:
> /home/larrys/perforce/trees/dev/linux/Pkgs/source/wget
> 
> Andy,
>       If you have any comments, suggestions, etc. let me know ASAP. I
> think this is the correct way to handle this defect, but maybe you
> have another idea.
> 
> Thanks,
> 
> Larry
> 
> Change 30173 by larrys@larrys-r14-dmip on 2008/07/24 14:18:39
> *pending*
> 
>         TED00024850 COUGAR - system upgrade fails due to wget seg
> fault
> 
>         Wget has its own wrappers for malloc calls that check for 
>         memory exhaustion. Our malloc wrappers in libanpssc were
> creating
>         a recusrive call loop resulting in a segmentation fault when
> wget
>         was invoked. Link libc.so ahead of libanpssc.so resolves this
>         conflict.
>         Reviewed by: rendellf
> 
> Affected files ...
> 
> ... //depot/dev/linux/Pkgs/binary/Deb/wget_1.10.2-2_mipsel.deb#2 edit
> ... //depot/dev/linux/Pkgs/source/wget/debianrules.patch#1 edit






> Change 30173 by larrys@larrys-r14-dmip on 2008/07/24 14:18:39
> *pending*
> 
> 	TED00024850 COUGAR - system upgrade fails due to wget seg
> fault 
> 	Wget has its own wrappers for malloc calls that check for 
> 	memory exhaustion. Our malloc wrappers in libanpssc were
> creating a recusrive call loop resulting in a segmentation fault when
> wget was invoked. Link libc.so ahead of libanpssc.so resolves this
> 	conflict.
> 	Reviewed by: rendellf

hey, I reviewed it, and haven't approved it!




linux/Pkgs/binary/Deb/wget_1.10.2-2_mipsel.deb

     looks good

linux/Pkgs/source/wget/debianrules.patch

     i don't like it.  something must be wrong with what max did,
     because we didn't have this problem with any other library.
     only after he made that change.  something must be broken about
     that change.


