AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080724162207.7d7e0516@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9753@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 24 Jul 2008 16:23:36 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review change 30173
Message-ID: <20080724162336.3367fa7f@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9753@onstor-exch02.onstor.net>
References: <20080724150355.39d1affb@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9753@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

That's exactly what it is.

I'm back online now, so I will spend a few moments looking at a couple
of things.

On Thu, 24 Jul 2008 15:12:40 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Okay, what is the next step? The gdb trace looks like a recursive loop
> -or whatever you want to call this:
> 
> Core was generated by `/usr/bin/wget
> ftp://upgrade:password@10.0.0.143/DEV/Whatever.tar.gz'.
> Program terminated with signal 11, Segmentation fault.
> #0  0x2ba4a804 in pthread_once () from /lib/libpthread.so.0
> (gdb) bt
> #0  0x2ba4a804 in pthread_once () from /lib/libpthread.so.0
> #1  0x2b4fe3ec in _dlerror_run () from /lib/libdl.so.2
> #2  0x2b4fe04c in dlsym () from /lib/libdl.so.2
> #3  0x2ac7aba0 in calloc (nmemb=1, sz=16) at malloc-override.c:46
> #4  0x2b4fe488 in _dlerror_run () from /lib/libdl.so.2
> #5  0x2b4fe04c in dlsym () from /lib/libdl.so.2
> #6  0x2ac7aba0 in calloc (nmemb=1, sz=16) at malloc-override.c:46
> #7  0x2b4fe488 in _dlerror_run () from /lib/libdl.so.2
> #8  0x2b4fe04c in dlsym () from /lib/libdl.so.2
> #9  0x2ac7aba0 in calloc (nmemb=1, sz=16) at malloc-override.c:46
> #10 0x2b4fe488 in _dlerror_run () from /lib/libdl.so.2
> #11 0x2b4fe04c in dlsym () from /lib/libdl.so.2
> #12 0x2ac7aba0 in calloc (nmemb=1, sz=16) at malloc-override.c:46
> #13 0x2b4fe488 in _dlerror_run () from /lib/libdl.so.2
> #14 0x2b4fe04c in dlsym () from /lib/libdl.so.2
> #15 0x2ac7aba0 in calloc (nmemb=1, sz=16) at malloc-override.c:46
> #16 0x2b4fe488 in _dlerror_run () from /lib/libdl.so.2
> #17 0x2b4fe04c in dlsym () from /lib/libdl.so.2
> #18 0x2ac7aba0 in calloc (nmemb=1, sz=16) at malloc-override.c:46
> #19 0x2b4fe488 in _dlerror_run () from /lib/libdl.so.2
> #20 0x2b4fe04c in dlsym () from /lib/libdl.so.2
> #21 0x2ac7aba0 in calloc (nmemb=1, sz=16) at malloc-override.c:46
> #22 0x2b4fe488 in _dlerror_run () from /lib/libdl.so.2
> 
> Did you look at xmalloc.c in
> /home/larrys/perforce/trees/dev/linux/Pkgs/source/wget/wget-1.10.2/src?
> 
> I think we have a case of a wrapper calling a wrapper and not getting
> to the "official" malloc call.
> 
> Do you have a suggestion?
> 
> Larry
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, July 24, 2008 3:04 PM
> To: Larry Scheer
> Subject: Re: Please review change 30173
> 
> On Thu, 24 Jul 2008 14:29:32 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > Rendell,
> >     Andy is out and I don't know how fast he can respond to this
> > review request. Please review this change.
> > 
> > It is on my workspace on linux-compile:
> > /home/larrys/perforce/trees/dev/linux/Pkgs/source/wget
> > 
> > Andy,
> >       If you have any comments, suggestions, etc. let me know ASAP.
> > I think this is the correct way to handle this defect, but maybe you
> > have another idea.
> > 
> > Thanks,
> > 
> > Larry
> > 
> > Change 30173 by larrys@larrys-r14-dmip on 2008/07/24 14:18:39
> > *pending*
> > 
> >         TED00024850 COUGAR - system upgrade fails due to wget seg
> > fault
> > 
> >         Wget has its own wrappers for malloc calls that check for 
> >         memory exhaustion. Our malloc wrappers in libanpssc were
> > creating
> >         a recusrive call loop resulting in a segmentation fault when
> > wget
> >         was invoked. Link libc.so ahead of libanpssc.so resolves
> > this conflict.
> >         Reviewed by: rendellf
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/Pkgs/binary/Deb/wget_1.10.2-2_mipsel.deb#2
> > edit ... //depot/dev/linux/Pkgs/source/wget/debianrules.patch#1 edit
> 
> 
> 
> 
> 
> 
> > Change 30173 by larrys@larrys-r14-dmip on 2008/07/24 14:18:39
> > *pending*
> > 
> > 	TED00024850 COUGAR - system upgrade fails due to wget seg
> > fault 
> > 	Wget has its own wrappers for malloc calls that check for 
> > 	memory exhaustion. Our malloc wrappers in libanpssc were
> > creating a recusrive call loop resulting in a segmentation fault
> > when wget was invoked. Link libc.so ahead of libanpssc.so resolves
> > this conflict.
> > 	Reviewed by: rendellf
> 
> hey, I reviewed it, and haven't approved it!
> 
> 
> 
> 
> linux/Pkgs/binary/Deb/wget_1.10.2-2_mipsel.deb
> 
>      looks good
> 
> linux/Pkgs/source/wget/debianrules.patch
> 
>      i don't like it.  something must be wrong with what max did,
>      because we didn't have this problem with any other library.
>      only after he made that change.  something must be broken about
>      that change.
> 
> 
