AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080725040619.4799575b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<jonathan.goldick@onstor.com>,<vikas.saini@onstor.com>,<paul.hammer@onstor.com>,<brian.stark@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0B0C6C10@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 25 Jul 2008 04:09:32 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Jonathan Goldick" <jonathan.goldick@onstor.com>
Cc: "Vikas Saini" <vikas.saini@onstor.com>, "Paul Hammer"
 <paul.hammer@onstor.com>, "Brian Stark" <brian.stark@onstor.com>
Subject: Re: PERFORCE change 30178 for review
Message-ID: <20080725040932.1022b9ef@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0B0C6C10@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0B0C6C10@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 24 Jul 2008 21:53:19 -0700 "Jonathan Goldick"
<jonathan.goldick@onstor.com> wrote:

> Note that I am letting Andy drive getting this into r400rel since
> there is a change from him and Warren pending to make this fully
> functional.

Quite an exceptional use of the word "letting."  Kind of like how
Keitel "let" Rommel commit suicide?

> I have tested this on Spec and the regression is as follows:
> 
> 1. volume create/delete with and without the prom model number set to
> the 6520, vs. the 6720.
> 
> 2. system show chassis and system show version should only show fp0
> and fp1, fp2/fp3 are not started so you cannot rcon to them either.
> 
> 
> The regression is very simple because this is not really a major
> change.
> 
> In spec testing there was very little performance impact, roughly 10%
> so timings are not really affected either.  Basically txrx dominates
> our performance limits in cougar.
> 
> 
> I will be in the air in the morning so cannot help much but didn't
> want you blocked on me.
> 
> This code has no impact of any kind if we do not alter the model
> number in the prom.
> 
> 
> 
> -----Original Message-----
> From: Jonathan Goldick 
> Sent: Thursday, July 24, 2008 9:40 PM
> To: Amit Bothra; Andy Sharp; Chris Vandever; Danqing Jin; Deepak
> Veliath; Henry Lau; Ian Brown; Jan Seidel; Jobi Ariyamannil; Jonathan
> Goldick; Larry Scheer; Maxim Kozlovsky; Mike Lee; Narain Ramadass; Ram
> Upendran; Sandrine Boulanger; Sripal Surendiran (HCL); Svati Chandra;
> YiFeng Liu
> Subject: PERFORCE change 30178 for review
> 
> Change 30178 by jong@jong-jong-cifs on 2008/07/24 21:37:27
> 
> 	Add runtime support for 6520 and 3510 models.  These models
> have 2
> 	       fp cores disabled so that we delivered 90% of the
> 6720/3710 performance
> 	
> 	       This addresses most of defect TED00024776 Add support
> for alternate cougar models
> 	
> 	
> 	       There are other changes needed for Prom and the Linux
> kernel to
> 	       complete this support
> 	
> 	       Reviewed by MaximK
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/Includes/bc/FCNIM/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/bc/NFP_FP/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/bc/NFP_TXRX/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/bc/SSC/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/bl/FCNIM/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/bl/NFP_FP/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/bl/NFP_TXRX/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/bl/SSC/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/cg/NFP_FP/smp-api.h#3 edit
> ... //depot/dev/nfx-tree/Includes/cg/NFP_TXRX/smp-api.h#4 edit
> ... //depot/dev/nfx-tree/Includes/cg/SSC/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/ch/FCNIM/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/ch/NFP_FP/smp-api.h#3 edit
> ... //depot/dev/nfx-tree/Includes/ch/NFP_TXRX/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/ch/SSC/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/ch/SSC_MGMT/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Includes/smp-api.h#2 edit
> ... //depot/dev/nfx-tree/Makefile.fp#7 edit
> ... //depot/dev/nfx-tree/code/sm-chassis/chassis-ui.c#22 edit
> ... //depot/dev/nfx-tree/code/sm-chassis/chassisd-cg.c#12 edit
> ... //depot/dev/nfx-tree/code/sm-chassis/cm-msg.c#8 edit
> ... //depot/dev/nfx-tree/code/sm-dcache/dcache-tune.c#5 edit
> ... //depot/dev/nfx-tree/code/sm-dp-proxy/dp-proxy-init.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-eee/eee-desc.c#14 edit
> ... //depot/dev/nfx-tree/code/sm-eee/eee-init.c#8 edit
> ... //depot/dev/nfx-tree/code/sm-eee/eee-poll.c#7 edit
> ... //depot/dev/nfx-tree/code/sm-eee/eee.h#7 edit
> ... //depot/dev/nfx-tree/code/sm-except/crash-halt.c#16 edit
> ... //depot/dev/nfx-tree/code/sm-except/exc-init.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-buf.c#73 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-dnlc.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-inode.c#58 edit
> ... //depot/dev/nfx-tree/code/sm-fs/fs-rdwr.c#25 edit
> ... //depot/dev/nfx-tree/code/sm-lock/lock-internal.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-lock/lock.c#3 edit
> ... //depot/dev/nfx-tree/code/sm-mgmt-bus/mgmt-bus-emb.c#6 edit
> ... //depot/dev/nfx-tree/code/sm-mgmt-bus/mgmt-bus-emb.h#4 edit
> ... //depot/dev/nfx-tree/code/sm-open/fcb-api.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-open/fcb-struct.h#2 edit
> ... //depot/dev/nfx-tree/code/sm-prof/gmon.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250/ecc.c#6 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250/mem-api.c#10 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250/mem-api.h#3 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250/pte.c#11 edit
> ... //depot/dev/nfx-tree/code/sm-sb1250/smp.c#6 edit
> ... //depot/dev/nfx-tree/code/sm-serio/sbuart.c#9 edit
> ... //depot/dev/nfx-tree/code/sm-spinlock/spinlock-test.c#4 edit
> ... //depot/dev/nfx-tree/code/sm-stats/kpi-api.c#5 edit
> ... //depot/dev/nfx-tree/code/sm-stats/kpi.h#16 edit
> ... //depot/dev/nfx-tree/code/sm-test/test.c#12 edit
> ... //depot/dev/nfx-tree/code/sm-utils/chassis-utils.c#5 edit
> ... //depot/dev/nfx-tree/fp.ld.cmd#4 edit
> ... //depot/dev/nfx-tree/txrx.ld.cmd#2 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/30178?ac=10
