AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070322134349.068a5203@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>,<ken.renshaw@onstor.com>,<tim.gardner@onstor.com>,<jonathan.goldick@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	BB375AF679D4A34E9CA8DFA650E2B04E022156AE@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 22 Mar 2007 13:44:03 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Cc: Ken Renshaw <ken.renshaw@onstor.com>, Tim Gardner
 <tim.gardner@onstor.com>, Jonathan Goldick <jonathan.goldick@onstor.com>
Subject: Re: PERFORCE change 23229 for review
Message-ID: <20070322134403.248e8376@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E022156AE@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E022156AE@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Ken, Larry,

Can we change this please?  Shouldn't be too difficult, should it?  To
reiterate from a previous email thread, I think all changes to
makefiles and .js files and .S files and .sh files and .mk files should
be added to the review pre-checkin trigger.  My point is that either
the review process makes sense or it doesn't.  If it does, then we
should be doing it for all these files and maybe a few others that I
can't think of at the moment.

a



On Thu, 22 Mar 2007 13:03:14 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
> 	JFYI, I forgot to add Charissa as the reviewer on this change
> list.
> P4 doesn't check for reviewers if there are no .c or .h files in the
> change list.
> 
> -----Original Message-----
> From: Larry Scheer 
> Sent: Thursday, March 22, 2007 1:01 PM
> To: Andy Sharp; Brian DeForest; Charissa Willard; Chris Vandever;
> Danqing Jin; Henry Lau; Ian Brown; Jeseem S; Jobi Ariyamannil;
> Jonathan Goldick; Ken Renshaw; Larry Scheer; Maxim Kozlovsky; Nagendra
> Subramanya; Sandrine Boulanger; Tim Gardner
> Subject: PERFORCE change 23229 for review
> 
> Change 23229 by larrys@larrys-verify-depot on 2007/03/22 11:47:48
> 
> 	Fixes for incremental builds over NFS. The help.sh script
> wasn't able
> 	to overwrite web/js/help.js. Also the user was being prompted
> to rename
> 	files that previously existed.
> 
> Affected files ...
> 
> ... //depot/FB-DELOREAN/nfx-tree/Tools/suffix.mk#8 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-webui/help.sh#7 edit
> 
