AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080725162108.46f63009@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>,<chris.vandever@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0B0C6EE6@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 25 Jul 2008 16:21:28 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Cc: "Chris Vandever" <chris.vandever@onstor.com>
Subject: Re: Code Review of Reboot Fixes Required for Cougar GA
Message-ID: <20080725162128.65506e57@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0B0C6EE6@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0B0C6EDE@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0AE229D2@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0B0C6EE6@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 25 Jul 2008 13:34:27 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Andy can't review that, it would be txrx and fp code. I'll find
> somebody.

Oh sure, I'm an FPidiot, rub it in.  But even if I wasn't I don't have
time at the moment.  Stupid useless executives want an update.  With
actual information.

But please do send me the changelist anyway so that at some later date
I can incorporate the necessary code into my changelist.

Tnx.

> _____________________________________________
> From: Chris Vandever 
> Sent: Friday, July 25, 2008 1:33 PM
> To: Maxim Kozlovsky; Andy Sharp
> Subject: RE: Code Review of Reboot Fixes Required for Cougar GA
> 
> That would be great!
> 
> Andy, will you be available to review it to make sure we don't
> re-introduce the kernel oops you were trying to fix?
> 
> ChrisV
> 
> _____________________________________________
> From: Maxim Kozlovsky 
> Sent: Friday, July 25, 2008 1:31 PM
> To: Chris Vandever; Andy Sharp
> Subject: RE: Code Review of Reboot Fixes Required for Cougar GA
> 
> The minimum change would be stopping txrx and fp without resetting
> them, nothing else needs to change. I can code that up since I am
> done with NDMP bug for now.
> 
> Max
> 
> _____________________________________________
> From: Chris Vandever 
> Sent: Friday, July 25, 2008 1:26 PM
> To: Maxim Kozlovsky; Andy Sharp
> Subject: Code Review of Reboot Fixes Required for Cougar GA
> 
> I'm reviewing code for Andy for the following defects:
> 
> #24067 Cougar-Beta: system config restore causes partner node to
> reboot #23034 Kernel crash: DBE in yenta_irq during shutdown
> 
> Both are scheduled as required for GA.  However, I am concerned that
> the proposed changes are too risky to put into the product at this
> point since they involve changing code in a lot of places that do
> reboot.  In the long run this is absolutely the right thing to do, to
> try to consolidate the code.  However, for the time being I would be
> more comfortable with the minimal changes required to fix these
> specific defects.
> 
> We need to address these somehow, and at this point I'm being more of
> a hindrance than a help.  Could the two of you, or the three of us,
> work together to determine the minimum change necessary to address
> these issues with the minimum risk?  I am willing to continue being
> the "code nazi" if desired, but I am not comfortable approving the
> current changes for GA.
> 
> Thanks.
> 
> ChrisV
> 
