AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080728221421.39c38945@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ian.brown@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	33D5007D-2D22-4EDD-B000-E0562F78D2D2@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 28 Jul 2008 22:15:14 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ian Brown <ian.brown@onstor.com>
Subject: Re: PERFORCE change 30216 for review
Message-ID: <20080728221514.2b76dd37@ripper.onstor.net>
In-Reply-To: <33D5007D-2D22-4EDD-B000-E0562F78D2D2@onstor.com>
References: <WEBMAILAbE6tDNrhxC600003601@mail.onstor.com>
	<33D5007D-2D22-4EDD-B000-E0562F78D2D2@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Dude, take a pill and let your panties untwist a bit.

This was a miscommunication, that's all.  No need to get all full of
yourself and act there's some big problem.  Me, you can yell at as
much as you want, but you need to take it easy with Henry, he's a
sensitive boy.



On Mon, 28 Jul 2008 18:53:57 -0700 Ian Brown <ian.brown@onstor.com>
wrote:

> wait a second Henry!
>=20
> Dude, this doesn't seem right, you come to me to get a review, then
> I send you back to make changes because I did not approve, so you go
> to Andy and get the exact changes I didn't approve of approved by him
> to check in?   that's not cool, that doesn't fly.
>=20
> You need to make the changes I required: you need to add the
> comments I asked you to add, and you need fix the log problem rather
> than this hack with increasing the timeout (or come up with a
> justification for the timeout increase I'm satisfied with).
>=20
> This is not team work, in fact it splits up a team, and makes me
> never want to work with you again, I don't trust you.  I don't trust
> you to write good code.  I don't trust you to care about what you're
> working on, and I don't want you working on our product if that's
> your attitude.  I don't trust you to care about the people you're
> working with.  Looks like you'll go around them and cheat if it's
> easier for you.  You probably won't get as far in your career by
> pulling this kind of stuff; you probably don't want to do that.
>=20
> You can set this straight by continuing through the review process =20
> with me, and by putting in the changes I requested and making sure =20
> that I approve of the changes before you do them.  Then you'll have =20
> made amends with me, and I'll let this incident go between us.
>=20
> Ian
>=20
>=20
>=20
>=20
> On Jul 28, 2008, at 5:05 PM, henryl wrote:
>=20
> Change 30216 by henryl@henryl-linux on 2008/07/28 17:00:43
>=20
> 	   TED00024799  Community Connect - 'system get all -c 8511'
> failed when trying to upload syslogs=09
> 	   Fixed-
> 	    Increase timeout value to 5 mins from 1 min for socat.
> 	    Disable job control to avoid printing sleep =E2=80=A6 message.
> 	   Reviewed by AndyS,
>=20
> Affected files ...
>=20
> ... //depot/dev/nfx-tree/code/ssc-support/support.sh#39 edit
>=20
>=20
> http://liszt:1818/@md=3Dd&cd=3D//depot/$c=3DG35@/30216?ac=3D10
>=20
