AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080730151222.47f9ad82@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<archana.Shanmugasundaram@onstor.com>,<sripal.surendiran@onstor.com>,<deepak.veliath@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0879BA5D@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 30 Jul 2008 15:12:38 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Archana Shanmugasundaram" <archana.Shanmugasundaram@onstor.com>
Cc: "Sripal Surendiran (HCL)" <sripal.surendiran@onstor.com>, "Deepak
 Veliath" <deepak.veliath@onstor.com>
Subject: Re: status on bug TED00023385 	NCM - sscccc:NOTICE: SSL_read()
 failed,
Message-ID: <20080730151238.1130f014@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0879BA5D@onstor-exch02.onstor.net>
References: <20080728164056.20cd57cf@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0879BA5C@onstor-exch02.onstor.net>
	<20080729143734.282cb13b@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0879BA5D@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

OK, sorry about that, I thought that cl had been submitted already.

Review:

> Change 29974 by perforce@archana-DEV on 2008/07/10 06:36:51 *pending*

Comment looks good.

> 	   Defect TED00023385 NCM - sscccc:NOTICE: SSL_read() failed,
> errno=11, errmsg (Resource temporarily unavailable) fd(12) Handled
> the return values of SSL_get_error more appropriately. Now
> readClientSocket handles the following SSL_read errors: 1.
> SSL_ERROR_ZERO_RETURN 2. SSL_ERROR_WANT_READ
> 	   3. SSL_ERROR_SYSCALL
> 	   4. SSL_ERROR_SSL
> 

nfx-tree/code/sm-sct/sct-ccc-ssl.c

     line 792, probably should set *bufferptr = NULL so that it isn't
     "something" for all the return -1s, and so you don't have to set
     it in line 956

     line 803, no space before malloc

     line 865, check if time went backwards; error out if it did

     line 919, trailing whitespace

     line 878, 888 potential for memory leak, just goto out

     line 955, move inside block above - if (buffer)







On Tue, 29 Jul 2008 22:09:29 -0700 "Archana Shanmugasundaram"
<archana.Shanmugasundaram@onstor.com> wrote:

> Hi Andy,
>  
> Hope you misunderstood my previous mail. I have handled the SSL_read
> errors more appropriately after QA reproduced it. I sent this
> change-id for your review. Regards,
> Archana
> 
> ________________________________
> 
> From: Andy Sharp
> Sent: Tue 7/29/2008 2:37 PM
> To: Archana Shanmugasundaram
> Cc: Sripal Surendiran (HCL); Deepak Veliath
> Subject: Re: status on bug TED00023385 NCM - sscccc:NOTICE:
> SSL_read() failed,
> 
> 
> 
> Just to be clear, this is first priority to get fixed/resolved.  QA
> has entered the info on reproducing this into the bug and it must be
> fixed by EOD Thursday.
> 
> Please let me know ASAP if there are any questions or problems.
> 
> Thanks,
> 
> a
> 
> 
> 
> On Tue, 29 Jul 2008 06:42:01 -0700 "Archana Shanmugasundaram"
> <archana.Shanmugasundaram@onstor.com> wrote:
> 
> > Hi Andy,
> > 
> > The following changes have been made in order to fix TED00023385.
> > 
> > Perforce change-id : 29974.
> > 
> > You can see the changes under /homes/archanas/work/new/nfx-tree/
> > 
> > Regards,
> > Archana
> >
> > archanas@compile2>p4 <mailto:archanas@compile2>p4>  describe 29974
> > Change 29974 by perforce@archana-DEV <mailto:perforce@archana-DEV>
> > on 2008/07/10 06:36:51 *pending*
> >
> >            Defect TED00023385 NCM - sscccc:NOTICE: SSL_read()
> > failed, errno=11, errmsg (Resource temporarily unavailable) fd(12)
> > Handled the return values of SSL_get_error more appropriately. Now
> > readClientSocket handles the following SSL_read errors: 1.
> > SSL_ERROR_ZERO_RETURN 2. SSL_ERROR_WANT_READ
> >            3. SSL_ERROR_SYSCALL
> >            4. SSL_ERROR_SSL
> > Affected files ...
> > ... //depot/dev/nfx-tree/code/sm-sct/sct-ccc-ssl.c#14 edit
> >
> >
> > ________________________________
> >
> > From: Andy Sharp
> > Sent: Mon 7/28/2008 4:40 PM
> > To: Archana Shanmugasundaram
> > Cc: Sripal Surendiran (HCL)
> > Subject: status on bug TED00023385 NCM - sscccc:NOTICE: SSL_read()
> > failed,
> >
> >
> >
> > Howdy,
> >
> > We need some status on this defect.  We are trying to wrap things up
> > and do a final build.  Please advise.
> >
> > Thanks,
> >
> > a
> >
> >
> 
> 
