AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080801154726.7ac6a5e9@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<henry.lau@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E05DA1ED8@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 1 Aug 2008 15:47:42 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Henry Lau" <henry.lau@onstor.com>
Subject: Re: Please code review
Message-ID: <20080801154742.6ded63e1@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E05DA1ED8@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E05DA1ED8@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

> Change 30279 by henryl@henryl-linux on 2008/08/01 14:58:56 *pending*
> 
> 	   TED00024966 S-Soak (G12R9) : "system reboot -y -s" failed
> due to nfxsh crash Fixed- Cleanup the stale lock in remount_lock().
> 	   Check the return value first from ensure_fs_writable()
> before proceed. Reviewed by AndyS.
> 

nfx-tree/code/sm-bsd-snmpd/agent/agent_onstor.c

     these changes are not necessary; please leave this file as is

nfx-tree/code/sm-ipmd-lib/ipmd-lib-linux.c

     these changes have a very high risk, and aren't really correct
     either, since there is no error return path to communicate to
     the caller that the intended action didn't happen.  until we get
     a specific bug regarding this, leave this code alone as well.

nfx-tree/code/ssc-genlib/fs.c

     line 168, the message is incorrect.  it should read "Warning:
     stale remount lock found.  Removing lock file.  Please exit nfxsh
     and log in again after command finishes."

     No need to put the filename or function name in there, since
     there's only one function that can output this error message.
     Also, this can only happen if a lock is stale, not if another
     application has the lock.


nfx-tree/code/ssc-nfxsh/cmd_flash.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_upgrade.c

     looks good




On Fri, 1 Aug 2008 15:03:50 -0700 "Henry Lau" <henry.lau@onstor.com>
wrote:

> Hi Andy,
> 
>  
> 
> TED00024966    S-Soak (G12R9) : "system reboot -y -s" failed due to
> nfxsh crash
> 
>  
> 
> P4 change 30279.
> 
> P4- henryl-linux 
> 
>  
> 
> Path - /homes/henryl/p4/dev/nfx-tree
> 
>  
> 
> Thanks,
> 
> Henry
> 
>  
> 
>  
> 
> Henry Lau
> Software engineer
> 
> ONStor, Inc.
> office: 408.963-2486
> 
> 
> 
> Henry.lau@onstor.com 
> http://www.onstor.com <http://www.onstor.com> 
> 
>  
> 
>  
> 
