AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080806173058.04f46a96@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>,<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0B31A541@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 6 Aug 2008 17:31:04 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Cc: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Code review request change 30305
Message-ID: <20080806173104.1845ad92@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0B31A541@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9789@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0B31A541@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

calloc will get the malloc hook as max described, i checked this a while
back.

On Wed, 6 Aug 2008 16:46:43 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Does not calloc in glibc eventually call malloc? You could try and see
> if calloc calls your malloc_hook.
> 
> _____________________________________________
> From: Larry Scheer 
> Sent: Wednesday, August 06, 2008 4:37 PM
> To: Andy Sharp; Maxim Kozlovsky
> Subject: Code review request change 30305
> 
> Andy, Max,
>      If you approve this change it can go in sometime after the 4.0
> release. I changed malloc-override.c to
> Use __malloc_hook and __realloc_hook as described in the man page.
> There wasn't a hook for calloc so I just re-used the calloc() wrapper
> from the original version.
> 
> I built libanpcc.so with this code and tested it with the wget that
> was getting a segmentation fault. With the library that has this
> change wget worked. I am currently running this library on my cougar
> doing traffic and rsync tests. So far so good.
> 
> Let me know what you think.
> 
> The change is in my perforce workspace hosted by mightydog: 
>      /homes/larrys/src/dev/nfx-tree/code/sm-anpssc
> 
> Change 30305 by larrys@larrys on 2008/08/06 16:24:54 *pending*
> 
>         Change our malloc wrappers so they don't interfere with other
> Linux
>         applications that use their own wrappers and are linked with
> our libraries. 
>         See TED00024850 COUGAR - system upgrade fails due to wget seg
> fault.
> 
>         Regression focus: SSC Applications should crash when they run
> out of
>         memory -- see TED24786. 
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-anpssc/malloc-override.c#1 edit
