AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<david-b@pacbell.net>,<rtc-linux@googlegroups.com>,<akpm@linux-foundation.org>,<angelo.castello@st.com>,<anemo@mba.ocn.ne.jp>,<lethal@linux-sh.org>,<thomas.hommel@gefanuc.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	200808061711.49022.david-b@pacbell.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 6 Aug 2008 18:35:04 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: David Brownell <david-b@pacbell.net>
Cc: rtc-linux@googlegroups.com, Andrew Morton <akpm@linux-foundation.org>,
 Angelo Castello <angelo.castello@st.com>, Atsushi Nemoto
 <anemo@mba.ocn.ne.jp>, Paul Mundt <lethal@linux-sh.org>, Thomas Hommel
 <thomas.hommel@gefanuc.com>
Subject: Re: [patch 2.6.27-rc2] rtc: file close() consistently disables
 repeating irqs
Message-ID: <20080806183504.4aedf26b@ripper.onstor.net>
In-Reply-To: <200808061711.49022.david-b@pacbell.net>
References: <200808061711.49022.david-b@pacbell.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 6 Aug 2008 17:11:48 -0700 David Brownell <david-b@pacbell.net>
wrote:

> From: David Brownell <dbrownell@users.sourceforge.net>
> 
> Make the rtc framework consistent about disabling 1/second update IRQs
> that may have been activated through the /dev interface, when
> that /dev file is closed.  (It may have closed because of coredump,
> etc.)  This was previously done only for emulated update IRQs ...
> now, do it always.
> 
> Also comment the current policy:  repeating IRQs (periodic, update)
> that userspace enabled will be cleanly disabled, but alarms are left
> alone. Such repeating IRQs are a constant and pointless system load.
> 
> Update some RTC drivers to remove now-needless release() methods.
> Most such methods just enforce that policy.  The others all seem to
> be buggy, and mistreat in-kernel clients of periodic or alarm IRQs.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Acked-by: Andrew Sharp <andy.sharp@onstor.com>
