AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080807201202.452372e7@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624C0E@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 7 Aug 2008 20:12:28 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review - change 29896
Message-ID: <20080807201228.04d9b142@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624C0E@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E09624C0E@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

> Change 29896 by rendellf@rendellf-test on 2008/06/30 09:38:07
> *pending*
> 
> 	Added "system reset" command to support node reset/halt for
> Cougar. Update system status as required after periodically checking
> cpu status in chassisd.

I don't understand that last sentence.

 
nfx-tree/code/sm-chassis/chassis-ui.c

     line 864, message says "can't execute node" ... what does that
     mean? replace 'execute' with %s and get rid of the %s after 'node'

     line 875, just say 'failed: minimum BMFPGA revision required for
     this operation is 4.' so your message matches your code

     line 893, say something more -- the blade will be stuck in halt
     in this case

     line 868 whitespace

nfx-tree/code/sm-chassis/chassisd-cg.c

     looks good

nfx-tree/code/sm-chassis/cm-api-cg.h

     looks good

nfx-tree/code/ssc-nfxsh/agile-man/cg/help_system_reset.txt

     >>add nfx-tree/code/ssc-nfxsh/agile-man/cg/help_system_reset.txt

     uh, no!  these are supposed to go undocumented.

nfx-tree/code/ssc-nfxsh/agile-man/ch/help_system_reset.txt

     >>add nfx-tree/code/ssc-nfxsh/agile-man/ch/help_system_reset.txt

     uh, no!  these are supposed to go undocumented.

nfx-tree/code/ssc-nfxsh/agile-man/help_system_reset.txt

     >>delete nfx-tree/code/ssc-nfxsh/agile-man/help_system_reset.txt

     exactly

nfx-tree/code/ssc-nfxsh/cmd_help.c

     line 3857 there is something funky going on here.  these aren't
     supposed to be documented, no help text.  maybe make this
     if defined(cougar OR cheetah) AND defined(DEBUG).  Then I guess
     you can add those help texts.

nfx-tree/code/ssc-nfxsh/cmd_system.c

     line 342, two new functions.  uh, what for?  nack.

     line 609, uh, well, no, you're supposed to do the same thing to
     yourself that you do to the buddy node, just issue an advisory
     message that they should use system reboot|halt instead first,
     and if they say to proceed anyway, then do the chassis command.



On Thu, 7 Aug 2008 17:04:44 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Andy,
> 
> The node reset feature has been tested with the help of BrianS.
> Please review.  I'm ready to submit it assuming there aren't any last
> minute command name changes required.
> 
> Thanks,
> Rendell
> 
> 
> Change: 29896
> 
> Client: rendellf-test
> 
> User:   rendellf
> 
> Description:
>     Added "system reset" command to support node reset/halt for
> Cougar. Update system status as required after periodically checking
> cpu status
>     in chassisd.
> 
> Files:
>     //depot/dev/nfx-tree/code/sm-chassis/chassis-ui.c   # edit
>     //depot/dev/nfx-tree/code/sm-chassis/chassisd-cg.c  # edit
>     //depot/dev/nfx-tree/code/sm-chassis/cm-api-cg.h    # edit
>  
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/cg/help_system_reset.txt
> # add
>  
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/ch/help_system_reset.txt
> # add
>     //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_system_reset.txt
> # delete    
>     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_help.c  # edit
>     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c    # edit
