AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070327173738.72dcd732@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E022156C6@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 27 Mar 2007 17:37:44 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Request for code review openbsd files
Message-ID: <20070327173744.0e3fe94b@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E022156C6@onstor-exch02.onstor.net>
References: <20070327165330.743e6402@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E022156C6@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Why build it if you're not going to install it?  Why not skip the whole
thing?

That's the only thing so go ahead and check in whatever you decide.

a

On Tue, 27 Mar 2007 17:04:54 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> >> Shouldn't this ifndef NOMAN go before the gzip.info line above?
> No the gzip.info: rule is the rule building the file not installing
> it. I only want to conditionally turn off the installation of
> gzip.info.
> 
> L.
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, March 27, 2007 4:54 PM
> To: Larry Scheer
> Subject: Re: Request for code review openbsd files
> 
> On Tue, 27 Mar 2007 16:50:36 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > Andy,
> >    Will you review my changes to openbsd files and if you approve I
> > will check them in.
> > 
> > File # 1 openbsd/stc/etc/mtree/4.4BSD.dist
> > Removed empty directyory: /usr/local/info from etc/mtree/4.4BSD.dist
> > so it doesn't get created on the filer any more:
> > 
> > ==== //depot/FB-DELOREAN/openbsd/src/etc/mtree/4.4BSD.dist#7 -
> >
> /home/larrys/perforce/trees/FB-DELOREAN/openbsd/src/etc/mtree/4.4BSD.dis
> > t ====
> > @@ -520,11 +520,6 @@
> >  # ./usr/local/sbin
> >  ..
> >  
> > -# ./usr/local/info
> > -info
> > -# ./usr/local/info
> > -..
> > -
> >  # ./usr/local/agile
> >  agile
> > 
> > File # 2 openbsd/src/gnu/usr.bin/gzip/Makefile 
> > Turned off installing gzip.info 
> > 
> > perforce/trees/FB-DELOREAN/openbsd/src/gnu/usr.bin/gzip/Makefile
> > ==== @@ -1,6 +1,9 @@
> >  #      $OpenBSD: Makefile,v 1.12 1999/02/25 04:24:28 millert Exp $
> >  #      $NetBSD: Makefile,v 1.17 1995/10/24 22:18:34 jtc Exp $
> >  
> > +# ONStor change, Don't build man pages or install gzip.info
> > +NOMAN= 1
> > +
> >  PROG=  gzip
> >  SRCS=  gzip.c zip.c deflate.c trees.c bits.c unzip.c inflate.c
> > util.c \ crypt.c lzw.c unlzw.c unlzh.c unpack.c getopt.c
> > @@ -36,9 +39,11 @@
> >  gzip.info:     gzip.texi
> >         ${MAKEINFO} -I${.CURDIR} ${.CURDIR}/gzip.texi
> >  
> > +.ifndef NOMAN
> 
> Shouldn't this ifndef NOMAN go before the gzip.info line above?
> 
> >  beforeinstall:
> >         ${INSTALL} ${INSTALL_COPY} -m 444 -o ${BINOWN} -g ${BINGRP}
> > *.info* \
> >                 ${DESTDIR}/usr/share/info
> > +.endif
> >  
> >  afterinstall:
> >         install -c -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
> > 
