AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080827100106.0b8e5b02@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0B6A8C60@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 27 Aug 2008 10:01:39 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: reminder - please review code change
Message-ID: <20080827100139.7dcf7470@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0B6A8C60@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0B6A8C60@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Wow, I'm really sorry this dragged on so long.  There's been a lot of
elephant dancing going on lately and it's hard to concentrate on the
job sometimes when spending some much time trying not to get stepped on.

It's hard for me to tell from just this diff, but if it compiles and
works, then it seems reasonable.  Obviously these macros already exist
so it can't be too crazy.  What version of openbsd did this change come
from?  2.9?  Anyway, it's OK.

On Tue, 26 Aug 2008 18:52:14 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> [edk@edk-linux ~]$ p4 describe 30516
> Change 30516 by edk@edk-dev on 2008/08/26 18:51:06 *pending*
> 
>         For TED 2516 [9388 - Dobson] BSD Crash - caused by script
>         Added alignments, based on newer versions of OpenBSD.
>         Reviewed by AndyS.
> 
> Affected files ...
> 
> ... //depot/dev/openbsd/src/sys/kern/uipc_usrreq.c#1 edit
> 
> [edk@edk-linux ~]$ p4 diff
> ==== //depot/dev/openbsd/src/sys/kern/uipc_usrreq.c#1 -
> /homes/edk/p4/dev/openbsd/src/sys/kern/uipc_usrreq.c ====
> 840,841c840,841
> <                               qfds = (cm->cmsg_len - sizeof *cm) /
> sizeof (int);
> <                               rp = (struct file **)(cm + 1);
> ---
> >                               qfds = (cm->cmsg_len -
> > CMSG_ALIGN(sizeof
> *cm)) / sizeof (int);
> >                               rp = (struct file **)CMSG_DATA(cm);
> 
