AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080902114425.05eed063@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<sripal.surendiran@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	48AD86AF.4010603@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 2 Sep 2008 11:48:53 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Sripal <sripal.surendiran@onstor.com>
Subject: Re: three bobcat to cougar migration defects
Message-ID: <20080902114853.7e00f7b1@ripper.onstor.net>
In-Reply-To: <48AD86AF.4010603@onstor.com>
References: <20080818193332.0a78593c@ripper.onstor.net>
	<48AAE72B.2050405@onstor.com>
	<48AD86AF.4010603@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit



nfx-tree/code/ssc-initial-config/migrate.sh

     localtime paragraph is wrong.  line 536, you delete a file, and
     then the very next line you use that file name as the source for
     a copy.  this whole paragraph should be more like:

     if [ -e "$LINUX_LOCALTIME_CONF" ]; then
         # check if localtime file has any soft link
         if [ -L $LINUX_LOCALTIME_CONF ] ; then
     	     TIMEZONE_LINK=`readlink $LINUX_LOCALTIME_CONF 2>/dev/null`
             # update linux timezone and localtime file when BSD localtime file
             # has valid softlink to timezone file
             if [ -e "$TIMEZONE_LINK" ] ; then
                 rm -f $LINUX_LOCALTIME_CONF
                 cp $TIMEZONE_LINK $LINUX_LOCALTIME_CONF
                 TIMEZONE_VAL=`echo $TIMEZONE_LINK | sed 's:/usr/share/zoneinfo/::'`
                 echo $TIMEZONE_VAL > $LINUX_TIMEZONE_CONF 2>/dev/null
             fi
         fi
     fi

     line 547, just do a sed -i, no need to use a temporary file

     line 553, ntp paragraph should look like this:

     cp $LINUX_NTP_TEMPLATE_CONF $TMP_CONF_FILE
     grep "server" $LINUX_NTP_CONF | grep -v "127.127.1.0" >> $TMP_CONF_FILE
     cp $TMP_CONF_FILE $LINUX_NTP_CONF

     rm -f $TMP_CONF_FILE

     In other words, no if, it should always do this.

     line 604, no need for a function that is only called once, and
     with no arguments.





On Thu, 21 Aug 2008 20:45:59 +0530 Sripal
<sripal.surendiran@onstor.com> wrote:

> Andy,
> 
> Please review the fix for the following bugs. I tested the fix by 
> simulating the problem, since I don't have proper working Cougar box.
> 
> 1. TED00025119 - Migration-Bobcat Version 3.3 to Cougar 4.0 has 
> inconsistent file format changes of /etc/hosts
> 2. TED00025124  - Migration-Bobcat Version 3.3 to Cougar 4.0 has 
> inconsistent file format changes to /etc/ntp.conf
> 3. TED00025125 - Migration-Bobcat Version 3.3 to Cougar 4.0 looses
> sytem time zone.and defaults to GMT.
> 
> Change id : 30465
> 
> [sripal@linux-compile ssc-initial-config]#p4 describe 30465
> Change 30465 by sripal@sripal-rdev on 2008/08/21 08:10:53 *pending*
> 
> 
>         Fix for following defects TED00025119, TED00025124 and
> TED00025125.
> 
>         Handled following errors during migration
>         1. Modified interface names in hosts file(sc1 -> sc0 and sc2
> ->sc1) 2. Converted ntp.conf file from Bobcat to Cougar format
>         3. Converted timezone conf file from Bobcat to Cougar
> 
>         Regression Focus:
>         After migration check the format of the following conf files
>         1. /etc/hosts
>         2. /etc/ntp.conf
>         3. /etc/localtime and /etc/timezone
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-initial-config/migrate.sh#3 edit
> 
> Thanks
> Sripal.
> 
> Sripal wrote:
> > Andy,
> >
> > I have the fix. But I don't have a Cougar box to test it. I have a 
> > Cougar (g7r10) booked in my name. But all the chassis related
> > commands are not working. It doesn't have volumes.
> >
> > Thanks,
> > Sripal.
> >
> > Andrew Sharp wrote:
> >> Hi Sripal,
> >>
> >> I have assigned 3 bobcat to cougar migration defects to you so
> >> that you could take a look at fixing them.  They should be
> >> relatively easy to fix.  Let me know if you have any questions.
> >>
> >> Thanks,
> >>
> >> a
> >>   
> >
