AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<jonathan.goldick@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0B8A5409@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 8 Sep 2008 11:36:02 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Jonathan Goldick" <jonathan.goldick@onstor.com>
Subject: Re: Please review this code for 4.0.1
Message-ID: <20080908113602.05080c0d@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0B8A5409@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0B8151A7@onstor-exch02.onstor.net>
	<20080908112003.0c17c2dd@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0B8A5409@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

OK.

On Mon, 8 Sep 2008 11:27:48 -0700 "Jonathan Goldick"
<jonathan.goldick@onstor.com> wrote:

> New versions in place
> See JG>
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Monday, September 08, 2008 11:20 AM
> To: Jonathan Goldick
> Subject: Re: Please review this code for 4.0.1
> 
> linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c
> 
> 	line 323, i'm sure you meant this to be (u16)
> 
> 	line 937, 942, I'd like the comment convention for the file
>         preserved.
> JG> Done
> 
> nfx-tree/code/sm-mgmt-bus/mgmt-bus-emb.c
> 
> 	line 170, i'm confused: this will always be defined to be 3500
> 	(for cougar builds) based on your changes to Tools.def, so
> 	setting anything in the seep will be fruitless.
> 
> JG> That was done temporarily just before you checked since Fay
> JG> needed a
> new 3500 build.  The defs.mk file is back to it's normal state.
> 
> 	line 183, 185: do these really need to be different defines?
> 	SMP_MAX_CPUS and SMP_MAX_REMOTE_CPUS seem to be the same
> thing.
> 
> JG> Yes, they need to be different.  The definitions invert depending
> JG> on
> whether it's the FP or TXRX code that includes this file.  Took me a
> while to get that one as well.  For txrx, SMP_MAX_CPUS is defined to
> be his(txrx) core count and SMP_MAX_REMOTE_CPUS is the number of FP
> cores. But, for the FP, SMP_MAX_CPUS is defined to be his(FP) core
> count and SMP_MAX_REMOTE_CPUS is the number of TXRX cores.
> 
> Everything else looks OK.  Except maybe Tools.def.
> 
> JG> yes, updated.  Fay has his new builds.
> 
> 
> 
> On Thu, 4 Sep 2008 16:15:40 -0700 "Jonathan Goldick"
> <jonathan.goldick@onstor.com> wrote:
> 
> > This addresses defect TED00025265 Add support for Pantera 3110 and
> > cougar 3310 models
> > 
> > The functional spec has been sent to dl-designreview if you need
> > background.
> > 
> > The spec tests have been done, the throughput tests are waiting on
> > Fay's setup as is the proof that the Pantera-3110 will use Nexsan
> > storage. The test on the limit on the number of filers in a cluster
> > of Pantera-3110 requires equipment I don't have so will have to be
> > done by QA.
> > 
> > 
> > 
> > 
> > 
> > The perforce client is jong-jong-cifs
> > The source tree is ~jong/src/dev
> > 
> > Warren, please review:
> > //depot/dev/prom/cg/code/sm-seep/seep.h
> > 
> > Andy, please review:
> > 
> >
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c
> >
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h
> > //depot/dev/nfx-tree/Tools/defs.mk
> > //depot/dev/nfx-tree/code/sm-mgmt-bus/mgmt-bus-emb.c
> > //depot/dev/nfx-tree/code/sm-mgmt-bus/mgmt-bus-emb.h
> > //depot/dev/nfx-tree/code/ssc-mgmt-bus/mgmt-bus.h
> > //depot/dev/nfx-tree/Includes/smp-api.h
> > //depot/dev/nfx-tree/code/sm-test/test.c
> > 
> > 
> > Rendell, please review:
> > //depot/dev/nfx-tree/code/sm-chassis/chassis-ui.c
> > //depot/dev/nfx-tree/code/sm-chassis/chassisd-cg.c
> > //depot/dev/nfx-tree/code/sm-chassis/chassisd-msg.c
> > //depot/dev/nfx-tree/code/sm-chassis/cm-api.h
> > //depot/dev/nfx-tree/code/sm-chassis/cm-msg.c
> > //depot/dev/nfx-tree/code/sm-seep/seep-ui.c
> > 
> > RonB, please review:
> > //depot/dev/nfx-tree/code/sm-dcache/dcache-api.c
> > //depot/dev/nfx-tree/code/sm-dcache/dcache-readahead.c
> > //depot/dev/nfx-tree/code/sm-eee/eee-poll.c
> > //depot/dev/nfx-tree/code/sm-req-queue/req-tbl.def
> > //depot/dev/nfx-tree/code/sm-tpl/tpl-ipc.c
> > //depot/dev/nfx-tree/code/sm-ui/cmdtable.c
> > //depot/dev/nfx-tree/code/sm-ui/uihdr.h
> > //depot/dev/nfx-tree/code/sm-utils/txrx-utils-api.c
> > //depot/dev/nfx-tree/code/sm-utils/txrx-utils-api.h
> > //depot/dev/nfx-tree/code/sm-stats/kpi.h
> > //depot/dev/nfx-tree/code/ssc-nfxsh/kpi-ui.c
> > 
> > Bill, please review:
> > //depot/dev/nfx-tree/code/sm-sdm/sdm-init.c
> > 
> > Chris, please review:
> > //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.c
> > //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.h
> > //depot/dev/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c
> > //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_cluster.c
> > 
> > Jim, please review
> > //depot/dev/nfx-tree/code/ssc-vsd/vs-daemon.c
> > //depot/dev/nfx-tree/code/ssc-vsd/vs-util.c
