AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080911141726.29fb742e@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9802@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 11 Sep 2008 14:17:51 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review 30671
Message-ID: <20080911141751.3c796e9a@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9802@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9802@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

> Change 30671 by larrys@larrys-r14-dmip on 2008/09/11 13:19:57
> *pending*
> 
> 	TED00024996 system upgrade should not work on the primary
> flash! 
> 	Change the default behavior to upgrade stanby flash. Left the
> '-s' command line option for backward compatibility with programs
> such as automated test scripts and user's habits.
> 	
> 	Updated help text to reflect change.
> 	
> 	Added -p as an undocumented way to upgrade the primary flash.
> This provides the capability to still upgrade a system whose standby
> 	flash is bad or missing.
> 	
> 	Regression focus: system upgrade tests Try system upgrade
> with and without the -s option.
> 	
> 	Also review the online help text for system upgrade.
> 	
> 	Reviewed by: AndyS
> 


nfx-tree/code/ssc-nfxsh/agile-man/help_system_upgrade.txt

     uh, looks like you are eliminating the ftp syntax that doesn't
     have user:password, but what if someone wants to set up an ftp
     server that doesn't have user password?  the description still
     says it's optional, BTW.

     Take out the -s documentation: this option should be deprecated.

nfx-tree/code/ssc-nfxsh/cmd_upgrade.c

     yes, leave the -s in the code like you've done, but I would take
     it out of the documentation: deprecating it.

     would you like to add an extra "are you sure?" type prompt if
     someone uses the -p option?




On Thu, 11 Sep 2008 13:23:02 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> This work was done on my linux-compile workspace that is mounted on
> ripper:
> 
> WS: /home/larrys/perforce/trees/dev/nfx-tree
> 
> Change 30671 by larrys@larrys-r14-dmip on 2008/09/11 13:19:57
> *pending*
> 
>         TED00024996 system upgrade should not work on the primary
> flash!
> 
>         Change the default behavior to upgrade stanby flash. Left the
> '-s'
>         command line option for backward compatibility with programs
> such as
>         automated test scripts and user's habits.
> 
>         Updated help text to reflect change.
> 
>         Added -p as an undocumented way to upgrade the primary flash.
> This
>         provides the capability to still upgrade a system whose
> standby flash is bad or missing.
> 
>         Regression focus: system upgrade tests Try system upgrade with
> and
>         without the -s option.
> 
>         Reviewed by: AndyS
> 
> Affected files ...
> 
> ...
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_system_upgrade.txt#3
> edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#36 edit
