AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9804@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 11 Sep 2008 17:20:23 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review 30671
Message-ID: <20080911172023.088e9dda@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9804@onstor-exch02.onstor.net>
References: <20080911155030.79e3c14b@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9804@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

looks good

On Thu, 11 Sep 2008 16:59:29 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Please re-review.
> 
>  
> 
> I added the "are you sure?" to the primary flash upgrade and I changed
> the "upgrade completed messages" to say which flash was upgraded. I
> remembered Henry mentioning to me that after a primary flash upgrade
> it said the "standby flash upgrade is complete." I fixed that bit. I
> think there may have even been a minor defect filed for that one.
> 
>  
> 
> I changed the help text and removed the -s option. I put the FTP text
> back to what it was. Since I don't have an FTP server that allows a
> file to be pulled without a login name and password, I don't know if
> it works as documented. Here is how linux-compile and a BSD system
> behaved:
> 
>  
> 
> system upgrade
> ftp://10.0.0.143/home/upgrade/R3.3.1.DEV-BCDBG-091108.tar.gz
> 
> Checking file system...
> 
> ...
> 
> Downloading external system software distribution.
> 
> Warning: changing optimization to space because minfree is less than
> 5%
> 
> hookup: 228: Onstor src ip = 0x0
> 
> Connected to 10.0.0.143.
> 
> 220 linux-compile.onstor.net FTP server (Version wu-2.6.2-8) ready.
> 
> 331 Guest login ok, send your complete e-mail address as password.
> 
> 230-The response 'root@' is not valid
> 
> 230-Next time please use your e-mail address as your password
> 
> 230-   for example: joe@eng216.onstor.lab
> 
> 230 Guest login ok, access restrictions apply.
> 
> Remote system type is UNIX.
> 
> Using binary mode to transfer files.
> 
> 200 Type set to I.
> 
> 250 CWD command successful.
> 
> 550 home/upgrade: No such file or directory.
> 
> Retrieving home/upgrade/R3.3.1.DEV-BCDBG-091108.tar.gz
> 
> local: R3.3.1.DEV-BCDBG-091108.tar.gz remote:
> R3.3.1.DEV-BCDBG-091108.tar.gz
> 
> 229 Entering Extended Passive Mode (|||33594|)
> 
> 550 R3.3.1.DEV-BCDBG-091108.tar.gz: No such file or directory.
> 
> 221-You have transferred 0 bytes in 0 files.
> 
> 221-Total traffic for this session was 782 bytes in 0 transfers.
> 
> 221-Thank you for using the FTP service on linux-compile.onstor.net.
> 
> 221 Goodbye.
> 
> Download failed.
> 
>  
> 
> At least system upgrade allowed the URL.
> 
>  
> 
> Larry
> 
>  
> 
>  
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, September 11, 2008 3:51 PM
> To: Larry Scheer
> Subject: Re: Please review 30671
> 
>  
> 
> It says that it will prompt you for a password if one is needed.  Some
> 
> ftp servers can be configured to immediately give you access with just
> 
> the user name, no password required, and the client itself defaults to
> 
> 'ftp' or 'anonymous' which are synonymous.  So the question is, will
> it
> 
> prompt you like it says it will or ?
> 
>  
> 
> On Thu, 11 Sep 2008 15:02:27 -0700 "Larry Scheer"
> 
> <larry.scheer@onstor.com> wrote:
> 
>  
> 
> > Quick question... I removed the FTP syntax that didn't specify a
> > user
> 
> > because it didn't work when I tested it against the ftp servers we
> 
> > have in house. But then I didn't have an FTP server that worked
> 
> > without a password.
> 
> > Do you know of one I can test against? Or do you know if that syntax
> 
> > actually works?
> 
> > 
> 
> > -----Original Message-----
> 
> > From: Andy Sharp 
> 
> > Sent: Thursday, September 11, 2008 2:18 PM
> 
> > To: Larry Scheer
> 
> > Subject: Re: Please review 30671
> 
> > 
> 
> > > Change 30671 by larrys@larrys-r14-dmip on 2008/09/11 13:19:57
> 
> > > *pending*
> 
> > > 
> 
> > >   TED00024996 system upgrade should not work on the primary
> 
> > > flash! 
> 
> > >   Change the default behavior to upgrade stanby flash. Left
> 
> > > the '-s' command line option for backward compatibility with
> 
> > > programs such as automated test scripts and user's habits.
> 
> > >   
> 
> > >   Updated help text to reflect change.
> 
> > >   
> 
> > >   Added -p as an undocumented way to upgrade the primary
> 
> > > flash. This provides the capability to still upgrade a system
> > > whose
> 
> > > standby flash is bad or missing.
> 
> > >   
> 
> > >   Regression focus: system upgrade tests Try system upgrade
> 
> > > with and without the -s option.
> 
> > >   
> 
> > >   Also review the online help text for system upgrade.
> 
> > >   
> 
> > >   Reviewed by: AndyS
> 
> > > 
> 
> > 
> 
> > 
> 
> > nfx-tree/code/ssc-nfxsh/agile-man/help_system_upgrade.txt
> 
> > 
> 
> >      uh, looks like you are eliminating the ftp syntax that doesn't
> 
> >      have user:password, but what if someone wants to set up an ftp
> 
> >      server that doesn't have user password?  the description still
> 
> >      says it's optional, BTW.
> 
> > 
> 
> >      Take out the -s documentation: this option should be
> > deprecated.
> 
> > 
> 
> > nfx-tree/code/ssc-nfxsh/cmd_upgrade.c
> 
> > 
> 
> >      yes, leave the -s in the code like you've done, but I would
> > take
> 
> >      it out of the documentation: deprecating it.
> 
> > 
> 
> >      would you like to add an extra "are you sure?" type prompt if
> 
> >      someone uses the -p option?
> 
> > 
> 
> > 
> 
> > 
> 
> > 
> 
> > On Thu, 11 Sep 2008 13:23:02 -0700 "Larry Scheer"
> 
> > <larry.scheer@onstor.com> wrote:
> 
> > 
> 
> > > This work was done on my linux-compile workspace that is mounted
> > > on
> 
> > > ripper:
> 
> > > 
> 
> > > WS: /home/larrys/perforce/trees/dev/nfx-tree
> 
> > > 
> 
> > > Change 30671 by larrys@larrys-r14-dmip on 2008/09/11 13:19:57
> 
> > > *pending*
> 
> > > 
> 
> > >         TED00024996 system upgrade should not work on the primary
> 
> > > flash!
> 
> > > 
> 
> > >         Change the default behavior to upgrade stanby flash. Left
> 
> > > the '-s'
> 
> > >         command line option for backward compatibility with
> > > programs
> 
> > > such as
> 
> > >         automated test scripts and user's habits.
> 
> > > 
> 
> > >         Updated help text to reflect change.
> 
> > > 
> 
> > >         Added -p as an undocumented way to upgrade the primary
> 
> > > flash. This
> 
> > >         provides the capability to still upgrade a system whose
> 
> > > standby flash is bad or missing.
> 
> > > 
> 
> > >         Regression focus: system upgrade tests Try system upgrade
> 
> > > with and
> 
> > >         without the -s option.
> 
> > > 
> 
> > >         Reviewed by: AndyS
> 
> > > 
> 
> > > Affected files ...
> 
> > > 
> 
> > > ...
> 
> > >
> 
> >
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_system_upgrade.txt#3
> 
> > > edit
> 
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#36 edit
> 
