AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080919175712.5f1fb062@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C982F@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 19 Sep 2008 17:57:25 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review change 30748
Message-ID: <20080919175725.2da187f8@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C982F@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C982F@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

> Change 30748 by larrys@larrys-r14-dmip on 2008/09/19 17:12:45
> *pending*
> 
> 	TED00025299 LSI Lab - Case9544 - file /etc/mdrive_fstab
> missing. system copy all -i writes to local filesystem
> 	
> 	In tweak_filesystem /etc/mdrive_fstab was being copied to
> 	/etc/fstab on the standby flash versus /etc/mdrive_fstab. This
> 	was overwriting the standby /etc/fstab we just created and
> 	not placing /etc/mdrive_fstab on the newly initialized flash.

It's all right to say what the code used to be doing.  Even better to
include what it will be doing after this change.

> 	Reviewed by: AndyS
 
nfx-tree/code/ssc-nfxsh/cmd_flash.c

     well, what if they just do a _system copy all_ without the -i?
     this looks like a typo, probably by me, but the file should also
     just get copied in the system copy all case.

     you should probably just add 30747 to this changelist too and
     have just one changelist, ja?




On Fri, 19 Sep 2008 17:41:21 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

>  Andy,
>    Please review this change. I think this is the correct thing to
> do. I tested the change on a bobcat and it is doing the right thing.
>     This work was done in my linux-compile workspace mounted on ripper
> in /home/larrys/perforce/trees/dev/nfx-tree/code/ssc-nfxsh
> 
> Thanks,
> 
> Larry
> 
> Change 30748 by larrys@larrys-r14-dmip on 2008/09/19 17:12:45
> *pending*
> 
>         TED00025299 LSI Lab - Case9544 - file /etc/mdrive_fstab
> missing. system copy all -i writes to local filesystem
> 
>         In tweak_filesystem /etc/mdrive_fstab was being copied to
>         /etc/fstab on the standby flash versus /etc/mdrive_fstab. This
>         was overwriting the standby /etc/fstab we just created and
>         not placing /etc/mdrive_fstab on the newly initialized flash.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#20 edit
