AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080923154926.271934f4@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9839@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 23 Sep 2008 15:49:37 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review change 30718 (system compare defect fixes)
Message-ID: <20080923154937.2c4f9899@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9839@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9839@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 23 Sep 2008 15:02:34 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Change 30718 by larrys@larrys-r14-dmip on 2008/09/17 15:58:49
> *pending*
> 
>         TED00024996 system upgrade should not work on the primary
> flash! Forgot to add the system upgrade help file to change 30684
> 
>         TED00024031 Cougar -system compare IPADDR:PATHNAME  Does not
> work
>         Update the system compare help file to reflect reality.
> 
>         TED00022795 system compare fails when the FTP path is provided
> without
>         the "password"
> 
>         Changed the command line parse routine in cmd_system to use
> the form_full_path routine. Changes the command line parsers to
> accept
>         the arguments in the same order as system upgrade. 
> 
>         Also made download of distribution file to perform a system
> compare
>         optional. System compare will now verify the software
> integrity of
>         either the primary or standby flash using the current manifest
> (AKA BOM)
>         file resident on the specified compact flash. (Primary is the
> default.)
> 
>         Reviewed by: RendellF and AndyS
> 
> Affected files ...
> 
> ...
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_system_compare.txt#1
> edit
> ...
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_system_upgrade.txt#3
> edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#59 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#37 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#9 edit


Nice change; good initiative.

Don't forget to email dl-ui about this change to the help text and
command synopsi.



nfx-tree/code/ssc-nfxsh/agile-man/help_system_compare.txt

     nice job

nfx-tree/code/ssc-nfxsh/agile-man/help_system_upgrade.txt

     looks good

nfx-tree/code/ssc-nfxsh/cmd_system.c

     line 1755ish, i think it's better style for one variable per line.
     i don't fix files that already exist, but ...

     [warning] white space nits:

     please put a blank line between declarations and code blocks...

     for loop: closing brace would seem to be indented incorrectly.

     c = 0 not c=0 (space around operators and identifiers, etc.)

     1798,9 join these lines





nfx-tree/code/ssc-nfxsh/cmd_upgrade.c

     line 1672, we don't use this function any more?  remove it then.

     line 2307, for loop spacing violation up the ying-yang.  ok,
     just 2.

     line 2347 perform_compare function, indentation is borken.
     actually, now that i look at it, the new code is correct, but
     the old code is indent-challenged.

     line 2422 not sure I follow your changes here.  you seem to
     be doing the compare always, even in cases where you output a
     message indicating that you aren't doing the compare (line 2442).
     and umount_patch seems not to be called under all the correct
     circumstances.

nfx-tree/code/ssc-nfxsh/verify_install.in

     i don't get the difference between DO_DOWNLOAD and USE_DOWNLOAD.
     there can't possibly be cases where you use it but don't download
     it or download it but don't use it.  that would make no sense. it
     is only ever checked to be 'no'.

     i don't think the small mfs is necessary.  it just makes things
     complicated.  can you not just use /tmp or the regular mfs?

     line 267, 274, 557, 561, 578, 606, 1070, ew trailing whitespace.
     line 1220 hidden spaces

     line 683, 699, DO_REINSTALL should have double quotes around it:
     if it isn't set, then the shell will just erp a syntax error.

     line 1206, i'm not sure fix_old_paths belongs inside this if block.
     shouldn't we always fix old paths in crontab if they are there?



