AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080929162620.2587cbe0@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624CAB@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 29 Sep 2008 16:26:36 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review - 30814
Message-ID: <20080929162636.60e93778@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624CAB@onstor-exch02.onstor.net>
References: <20080929154651.19b74905@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624CAB@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


nfx-tree/code/ssc-nfxsh/agile-man/help_system_modify_coredumpmaxsavedfiles.txt


     looks good


nfx-tree/code/ssc-nfxsh/cmd_system.c


     line 1451, my bad, i should have said something the last time,
     but a call to cluster_updateCoredump() can be avoided if
     coreDumpCfg.max_core_files == files

     i'll make that optional ~:^) you can check it in as is if you wish




On Mon, 29 Sep 2008 16:18:01 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Ok, I've re-ordered the parameter check.  Also, eliminated the check
> for less than 0 since strtoul() is being used.  Is this better?
> 
> 
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Monday, September 29, 2008 3:47 PM
> > To: Rendell Fong
> > Subject: Re: please review - 30814
> > 
> > > Change 30814 by rendellf@rendellf-test on 2008/09/29 11:27:11
> > > *pending*
> > >
> > > 	TED21376: "System modify coredumpmaxsavedfiles" accepts
> > > invalid values
> > > 	Changed argument check to ensure that the max files
> > > parameter is a number in entirety.
> > >
> > > 	TED17257: Coredumpmaxsavedfiles needs description of input
> > >
> > > 	Add missing command line help max number of files
> > > parameter. Update max files parameter description in help page.
> > 
> > nfx-tree/code/ssc-nfxsh/agile-
> > man/help_system_modify_coredumpmaxsavedfiles.txt
> > 
> >      looks good
> > 
> > nfx-tree/code/ssc-nfxsh/cmd_system.c
> > 
> >      line 1444, the appropriateness of the argument should be tested
> >      before the call to cluster_getCoredump(), thereby possibly
> avoiding
> >      that call and variable assignment in the error case.
> > 
> > 
> > 
> > 
> > On Mon, 29 Sep 2008 14:04:05 -0700 "Rendell Fong"
> > <rendell.fong@onstor.com> wrote:
> > 
> > > Change 30814 by rendellf@rendellf-test on 2008/09/29 11:27:11
> > > *pending*
> > >
> > >         TED21376: "System modify coredumpmaxsavedfiles" accepts
> > > invalid values
> > >
> > >         Changed argument check to ensure that the max files
> parameter
> > > is a number
> > >         in entirety.
> > >
> > >         TED17257: Coredumpmaxsavedfiles needs description of input
> > >
> > >         Add missing command line help max number of files
> > > parameter. Update max files parameter description in help page.
> > >
> > > Affected files ...
> > >
> > > ...
> > >
> //depot/dev/nfx-tree/code/ssc-nfxsh/agile-man/help_system_modify_coredum
> > > pmaxsavedfiles.txt#1 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#60 edit
