AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081002175741.2317a47f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624CB0@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 2 Oct 2008 17:59:25 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review - 30847
Message-ID: <20081002175925.5987114b@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624CB0@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E09624CB0@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 1 Oct 2008 16:16:35 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Change 30847 by rendellf@rendellf-test on 2008/10/01 16:10:46
> *pending*
> 
>         TED23774: support.sh returns "% Command failure" errors in the
> sfinfo files
> 
>         Changed nfxsh to setup default signal handler for SIGCHLD
> during initialization.  It ensures that the status return code of
> child processes created by nfxsh can be retrieved properly.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_main.c#16 edit


= Change 30847 by rendellf@rendellf-test on 2008/10/01 16:10:46
= *pending*
= 
= 	TED23774: support.sh returns "% Command failure" errors in
= the sfinfo files 
= 	Changed nfxsh to setup default signal handler for SIGCHLD
= during initialization.  It ensures that the status return code of
= child processes created by nfxsh can be retrieved properly.


nfx-tree/code/ssc-nfxsh/vtysh_main.c

     line 191, as long as you're going to add the void, might as well
     remove the space after the function name.

     Will this possibly screw up socat?  Is it setting the sigchild
     handler to something special that it is expecting that now won't
     happen?  How long have you run this on your cougar for?

