AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624CB9@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 7 Oct 2008 11:44:32 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review - 30863
Message-ID: <20081007114432.76dc8f0f@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624CB9@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E09624CB9@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 6 Oct 2008 11:50:25 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Change 30863 by rendellf@rendellf-test on 2008/10/03 15:29:50
> *pending*
> 
>         TED22611: elog don't display the updated time when time zone
> is changed
> 
>         Changed to sync time zone updates with elog daemon, syslog
> daemon, and
>         the nfx shell from which the update was made.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-elog/elog.c#10 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-linux.c#11 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c#11 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#62 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#14 edit



= Change 30863 by rendellf@rendellf-test on 2008/10/03 15:29:50
*pending* = 
= 	TED22611: elog don't display the updated time when time zone
is changed = 	TED17176: Changing system time zone doesn't change
time in nfxsh -t prompt = 	
= 	Changed to sync time zone updates with elog daemon, syslog
daemon, and = 	the nfx shell from which the update was made.
= 

nfx-tree/code/ssc-elog/elog.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_system-linux.c

     this shouldn't really be necessary -- syslogd will get the
     time, no?  or is this necessary to get it to adopt the TZ change?
     it shouldn't be necessary for just the time.

nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c

     ok, now i'm really confused, is it needed or not?

nfx-tree/code/ssc-nfxsh/cmd_system.c

     line 2120, er, no this isn't the right way to do this.

nfx-tree/code/ssc-nfxsh/nfxsh.h

     looks good

