AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070402140801.53eaa982@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 2 Apr 2007 14:08:29 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Maxim Kozlovsky <maxim.kozlovsky@onstor.com>
Subject: code reviewr request: one line change to cmd_flash.c; TED00018217
Message-ID: <20070402140829.32de7ee0@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

TED00018217:

Bunch of extraneous garbage spews out during various nfxsh commands:

system vers -s
read fields=3 fdev='/dev/wd1a', fdir='/', ftype='ffs'
read fields=3 fdev='/dev/wd1e', fdir='/tmp', ftype='ffs'
read fields=3 fdev='/dev/wd1d', fdir='/usr', ftype='ffs'
read fields=3 fdev='/dev/wd1g', fdir='/usr/local/agile', ftype='ffs'
read fields=3 fdev='/dev/wd1f', fdir='/var', ftype='ffs'
read fields=3 fdev='/dev/wd1h', fdir='/usr/local/agile/conf', ftype='ffs'
read fields=-1 fdev='/dev/wd1h', fdir='/usr/local/agile/conf', ftype='ffs'
fields=-1, ftype='ffs'
mount_secondary: fs_file=/, fs_vfstype=ffs, fs_spec=/dev/wd1a
mount_secondary: fs_file=/tmp, fs_vfstype=ffs, fs_spec=/dev/wd1e
mount_secondary: fs_file=/usr, fs_vfstype=ffs, fs_spec=/dev/wd1d
mount_secondary: fs_file=/usr/local/agile, fs_vfstype=ffs, fs_spec=/dev/wd1g
mount_secondary: fs_file=/var, fs_vfstype=ffs, fs_spec=/dev/wd1f
mount_secondary: fs_file=/usr/local/agile/conf, fs_vfstype=ffs, fs_spec=/dev/wd1h
2.3.0.0


This is debug output that was supposed to be disabled before checkin.
The fix is to remove the hardcoded definition of DEBUG macro from the .c

p4 diff nfx-tree/code/ssc-nfxsh/cmd_flash.c
==== //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#5 - /homes/andys/src/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c ====
88,89d87
< #define DEBUG 1
< 
