AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081023144634.251e0271@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0C19C851@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 23 Oct 2008 14:47:22 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: Please review sendmail code change for TED 25593
Message-ID: <20081023144722.0b37b29f@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0C19C851@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0C19C851@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 22 Oct 2008 19:34:41 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> Hi Andy,
> 
> We were ignoring the "-f" flag so the sendmail $g macro was not set
> properly.
> 
> Thanks,
> Ed
> 
> 
> [edk@edk-linux nfx-tree]$ p4 describe 30991
> Change 30991 by edk@edk-dev on 2008/10/22 19:26:37 *pending*
> 
>         For TED 25593 - Autosupport 'from' configuration ignored
>         Add back the support for the "-f" flag, so the sendmail $g
>         macro is set correctly.
>         Reviewed by AndyS.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sendmail/sendmail/main.c#2 edit



= Change 30991 by edk@edk-dev on 2008/10/22 19:26:37 *pending*
= 
= 	For TED 25593 - Autosupport 'from' configuration ignored
= 	Add back the support for the "-f" flag, so the sendmail $g
= 	macro is set correctly.
= 	Reviewed by AndyS.

comment is ok

nfx-tree/code/sendmail/sendmail/main.c

     looks a bit ugly.  better to swith the order of the f and r case
     statements, and make the 'break' NFX-optional for the 'r'.

     case 'r':
     #ifdef NFX
     	break;
     #endif
     case 'f':
     	.
	.
	.

