AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0C2D1CE4@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 29 Oct 2008 10:31:26 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Ping: Please review change 30961 OpenLDAP package build
 Makefile and friends
Message-ID: <20081029103126.6be8142c@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0C2D1CE4@onstor-exch02.onstor.net>
References: <20081028174508.6fc2cd73@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0C2D1CE4@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

ok

On Tue, 28 Oct 2008 19:30:29 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Comments in-line below
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, October 28, 2008 5:45 PM
> To: Larry Scheer
> Subject: Re: Ping: Please review change 30961 OpenLDAP package build
> Makefile and friends
> 
> On Tue, 28 Oct 2008 13:38:37 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > Andy,
> >     I still haven't heard from you regarding this change. I also
> > have Kerberos ready to review. If I don't hear back from you by 5
> > PM I will check in this LDAP change.
> 
> 
> = Change 30961 by larrys@larrys on 2008/10/15 16:37:33 *pending*
> = 
> = 	Files and source changes needed to build the OpenLDAP
> library packages = 	with ONStor changes for our virtual
> servers. These files and changes = 	allow Red Hat i386 and
> Ubuntu/Debian i386 desktops to cross-compile = 	and build the
> library packages using dpkg utilities. = 	Reviewed by: AndyS
> = 
> 
> linux/Pkgs/source/openldap2/Makefile
> 
> 
>      >>add linux/Pkgs/source/openldap2/Makefile
> 
>      lines 21, 40  trailing whitespace
> 
> LS -- fixed
> 
> linux/Pkgs/source/openldap2/README
> 
> 
>      >>add linux/Pkgs/source/openldap2/README
> 
>      some trailing whitespace
> 
> LS -- fixed
> 
> linux/Pkgs/source/openldap2/debianrules.patch
> 
> 
>      >>add linux/Pkgs/source/openldap2/debianrules.patch
> 
>      line 8, i should think you don't need the
>      -I/usr/mipsel-linux-gnu-gcc/include because the cross compiler
>      will do that automatically
> 
> LS -- You would think. But for some lame a$$ reason I needed it. Maybe
> it was Red Hat or maybe some busted libtool POS reason. I left in
> there 'cause it worked on all systems. Annoyed the begeezuz out of me.
> 
> 
> 
> linux/Pkgs/source/openldap2/mkpatch.sh
> 
> 
>      >>add linux/Pkgs/source/openldap2/mkpatch.sh
> 
>      cool
> 
> 
> linux/Pkgs/source/openldap2/onstor-src.dpatch
> 
> 
>      >>add linux/Pkgs/source/openldap2/onstor-src.dpatch
> 
>      i'm amazed that it takes this as a dpatch format, i thought it
>      had to be slightly different or have an extra header to be in
>      dpatch format.  or there's a command that will turn a normal
>      patch into a dpatch or whatever.
> 
>      massive gross amounts of trailing space in this.  i guess it's
> not your code, however.  what freakin slob of a programmer wrote this.
> 
> 
> linux/src/openldap-2.3.30/build/shtool
> 
> 
>      /homes/larrys/src/dev/linux/src/openldap-2.3.30/build/shtool
> 
>      uh, somehow i'm not getting a diff for this one
> 
>      it says edit but it's not an edit?
> 
> LS -- Looks like I opened it but made no change. It was so long ago I
> don't recall what my intention was.
> 
> linux/src/openldap-2.3.30/build/top.mk
> 
> 
>      greek
> 
> 
> linux/src/openldap-2.3.30/clients/tools/Makefile.in
> 
> 
>      why take out the strip?  if the all-arch binutils package is
>      installed, strip should work.
> LS -- Because it is install -s which on our Red Hat systems can't
> strip Mips binaries.
> 
> linux/src/openldap-2.3.30/debian/configure.options
> 
> 
>      looks good
> 
> 
> linux/src/openldap-2.3.30/debian/rules
> 
> 
>      line 7, hm, same comment as before: the -I/muble/fratz shouldn't
>      be needed.  And why are these being added to CPPFLAGS?  Should be
>      CFLAGS.  Unless it's really C++ code that needs these flags.
> 
> LS -- CPPFLAGS is C Pre-Processor FLAGS. Not C++ It gives you a way to
> split your compile flags into chunks in case you need one set of flags
> to come before or after another.
> 
> linux/src/openldap-2.3.30/debian/slapd.install
> 
> 
>      looks good
> 
> 
> linux/src/openldap-2.3.30/libraries/librewrite/Makefile.in
> 
> 
>      looks good
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> > Larry
> > 
> > _____________________________________________
> > From: Larry Scheer 
> > Sent: Wednesday, October 22, 2008 5:17 PM
> > To: Andy Sharp
> > Subject: Ping: Please review change 30961 OpenLDAP package build
> > Makefile and friends
> > 
> > Andy,
> >    I haven't heard from you regarding this change. Any comments?
> > 
> > Larry
> > 
> > _____________________________________________
> > From: Larry Scheer 
> > Sent: Wednesday, October 15, 2008 4:55 PM
> > To: Andy Sharp
> > Subject: Please review change 30961 OpenLDAP package build Makefile
> > and friends
> > 
> > Andy,
> >     These files are in my Mightydog workspace: /homes/larrys/src/dev
> > 
> > Change 30961 by larrys@larrys on 2008/10/15 16:37:33 *pending*
> > 
> >         Files and source changes needed to build the OpenLDAP
> > library packages
> >         with the ONStor changes for our virtual servers. These files
> > and changes
> >         allow a Red Hat i386 and Ubuntu/Debian i386 desktops to
> > cross-compile and
> >         build the library packages using dpkg utilities.
> >         Reviewed by: AndyS
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/Pkgs/source/openldap2/Makefile#1 add
> > ... //depot/dev/linux/Pkgs/source/openldap2/README#1 add
> > ... //depot/dev/linux/Pkgs/source/openldap2/debianrules.patch#1 add
> > ... //depot/dev/linux/Pkgs/source/openldap2/mkpatch.sh#1 add
> > ... //depot/dev/linux/Pkgs/source/openldap2/onstor-src.dpatch#1 add
> > ... //depot/dev/linux/src/openldap-2.3.30/build/shtool#1 edit
> > ... //depot/dev/linux/src/openldap-2.3.30/build/top.mk#1 edit
> > ... //depot/dev/linux/src/openldap-2.3.30/clients/tools/Makefile.in#1
> > edit
> > ... //depot/dev/linux/src/openldap-2.3.30/debian/configure.options#1
> > edit
> > ... //depot/dev/linux/src/openldap-2.3.30/debian/rules#1 edit
> > ... //depot/dev/linux/src/openldap-2.3.30/debian/slapd.install#1
> > edit ...
> >
> //depot/dev/linux/src/openldap-2.3.30/libraries/librewrite/Makefile.in#1
> > edit
