AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081104115444.000602e8@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB5175BF46166@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 4 Nov 2008 11:55:12 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Ping: Please review Change 31001 Kerberos package build
Message-ID: <20081104115512.30c49511@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB5175BF46166@exch1.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0C2D1CDF@onstor-exch02.onstor.net>
	<2779531E7C760D4491C96305019FEEB5175BF46166@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Really sorry for dropping this one, got confused by all this exim
crapola.  I'd like to talk about this some more.  Stop by when you have
a chance sometime tomorrow.



= Change 31001 by larrys@larrys on 2008/10/24 14:07:25 *pending*
= 
= 	Files and source changes needed to build the Kerberos5
library packages
= 	   with ONStor changes for our virtual servers. These files
and changes
= 	   allow Red Hat i386 and Ubuntu/Debian i386 desktops to
cross-compile
= 	and build the krb5 packages using dpkg utilities.
= 	   Reviewed by: AndyS
= 

linux/Pkgs/source/krb5/Makefile

     >>add linux/Pkgs/source/krb5/Makefile

     teensy bit of trailing whitespace

linux/Pkgs/source/krb5/README

     >>add linux/Pkgs/source/krb5/README

     also teensy bit of trailing whitespace

linux/Pkgs/source/krb5/debianrules.patch

     >>add linux/Pkgs/source/krb5/debianrules.patch

     ok

linux/Pkgs/source/krb5/mkpatch.sh

     >>add linux/Pkgs/source/krb5/mkpatch.sh

     cool

linux/Pkgs/source/krb5/onstor-src.dpatch

     >>add linux/Pkgs/source/krb5/onstor-src.dpatch

     yesus mary and yosef, this the mother of all patchess.  is it
     really the right way to do this? or should the patch just
     contain what is necessary for configure to output all this stuff?
     that sure would be a lot more maintainable.

     line 20767, 20791, etc., I would prefer that changes contain the
     string "onstor", in caps or otherwise, in mods to existing code.
     I know that in the past, in some instances, we've just used NFX
     as the grep-for string, but really that's pretty unintuitive
     unless you've been working here for a year already.  onstor and
     nfx together is fine.  if it's a big job to change that, then
     save it for next time. line 20808 is good enough because onstor
     is in there close to all the changes.

     line 20836  indenting - #stuff shouldn't be indented, and trailing
     whitespace on line 20838

     line 21401 trailing whitespace

linux/src/krb5-1.4.4/build/runstatus.sh

     line 3, what's wrong with the way it was, spelling out the
     directories explicitly?  allows you to have extra directories
     that are not part of the shebang.  you can then leave the for
     loop alone, except that it should not do an exit if a directory
     doesn't exist, it should do a continue.

linux/src/krb5-1.4.4/build/sedstatus.sh

     looks good

linux/src/krb5-1.4.4/debian/rules

     line 11, that's because on your ubuntu you have binutils-multiarch
     installed, but not on your RH workstation.  just install the
     multiarch version of binutils and it will work.

     line 24, please use a generic, not -4.1, because we might go to
     a new compiler version in a few months, or next year, and then
     you'd just have to change this again.








On Tue, 4 Nov 2008 11:10:09 -0800 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Hi Andy,
>      Any progress on this review?
> 
> Thanks,
> 
> Larry
> 
> _____________________________________________
> From: Larry Scheer
> Sent: Tuesday, October 28, 2008 1:53 PM
> To: Andy Sharp
> Subject: Please review Change 31001 Kerberos package build
> 
> Change 31001 by larrys@larrys on 2008/10/24 14:07:25 *pending*
> 
>         Files and source changes needed to build the Kerberos5
> library packages with ONStor changes for our virtual servers. These
> files and changes allow Red Hat i386 and Ubuntu/Debian i386 desktops
> to cross-compile and build the krb5 packages using dpkg utilities.
>            Reviewed by: AndyS
> 
> Affected files ...
> 
> ... //depot/dev/linux/Pkgs/source/krb5/Makefile#1 add
> ... //depot/dev/linux/Pkgs/source/krb5/README#1 add
> ... //depot/dev/linux/Pkgs/source/krb5/debianrules.patch#1 add
> ... //depot/dev/linux/Pkgs/source/krb5/mkpatch.sh#1 add
> ... //depot/dev/linux/Pkgs/source/krb5/onstor-src.dpatch#1 add
> ... //depot/dev/linux/src/krb5-1.4.4/build/runstatus.sh#1 edit
> ... //depot/dev/linux/src/krb5-1.4.4/build/sedstatus.sh#2 edit
> ... //depot/dev/linux/src/krb5-1.4.4/debian/rules#1 edit
> 
