AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070403195502.54454ed6@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E031DE995@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 3 Apr 2007 19:58:44 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070403195844.27526159@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E031DE995@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E031DE995@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 2 Apr 2007 16:41:49 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 
> ~/cg/nfx-tree
> 
> SSC compilation fixes, mostly one-liners. I've ifdefed out the places
> that do not compile or will not work on linux without substantial
> changes.

No ifdefs allowed.  Sole exception: ifdefs added by configure in open
source packages.


Files changed but not listed:

linux/include/net/neteee.h - looks ok, but what do i know
nfx-tree/code/sm-utils/Makefile - portable ? ok : not-ok
nfx-tree/code/ssc-openafs-lwp/preempt.c - ok
nfx-tree/code/ssc-openafs-rx/xdr_refernce.c - ok
nfx-tree/code/ssc-vtm/vtm.h - ok


Files in list:


> //depot/cougar/nfx-tree/Includes/bqueue.h#1 - edit default change

fix the ifndef linux.  the rest is ok.

> (text) //depot/cougar/nfx-tree/Includes/bsd-compat.h#1 - add default
> change (text)

ok

> //depot/cougar/nfx-tree/Includes/nfx-defs.h#2 - edit default change
> (text)

wong place for the protocol defs.  should be in one of the eee header
files.  one that will work in both user and kernel spaces.

> //depot/cougar/nfx-tree/Includes/nfx-incl.h#1 - edit default change
> (text)

no changes, please revert

> //depot/cougar/nfx-tree/Includes/nfx-ports.h#1 - edit default change
> (text)

no changes, please revert

> //depot/cougar/nfx-tree/Includes/rpc/rpc.h#1 - edit default change
> (text)

no ifdefs

> //depot/cougar/nfx-tree/Includes/rpc/xdr.h#1 - edit default change
> (text)

no ifdefs

> //depot/cougar/nfx-tree/Makefile.ssc#1 - edit default change (text)

you broke the formatting on sm-libc? undo unnecessary whitespace change

the sm-bsd-snmpd fix needs to be portable change, not just delete it
from the makefile.  ie., if you are doing the build on bsd, it needs to
be compiled, if you are doing the build on linux, it needs to be
[commented out of the list, probably]

> //depot/cougar/nfx-tree/Tools/defs.mk#3 - edit default change (text)

no sync'd with repository
-Wno-pointer-sign -- are you sure??  we don't want our pointers sign
extended?  ok then, if you're sure.  just resolve first.

> //depot/cougar/nfx-tree/Tools/suffix.mk#1 - edit default change (text)

changes don't look portable to me

> //depot/cougar/nfx-tree/code/sm-bsd-snmpd/agent/mibgroup/Makefile#1 -
> edit default change (text)

ok

> //depot/cougar/nfx-tree/code/sm-chassis/chassis-ui.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/sm-cifs/ntifs.h#1 - edit default change
> (xtext)

ok

> //depot/cougar/nfx-tree/code/sm-cifs/winerror.h#1 - edit default
> change (xtext)

please put platform stuff in a separate file.  is this platform or
compiler thing?  or glibc thing?  a compiler thing can stay, but not a
glibc or platform thing.

> //depot/cougar/nfx-tree/code/sm-dcache/dcache-msg.h#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/sm-event/emrs-api.h#1 - edit default
> change (text)

lose the ifdefs

> //depot/cougar/nfx-tree/code/sm-event/event-as.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/sm-evm/evm-cfgd-rx.c#1 - edit default
> change (text)

nice.  did you send that one back to the delorean folks?

> //depot/cougar/nfx-tree/code/sm-evm/evm-util.c#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/sm-evm/evm-util.h#1 - edit default change
> (text)

lose the NEW_LABEL_SCHEME macro, otherwise ok

> //depot/cougar/nfx-tree/code/sm-file/filesh.c#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/sm-fs/fs-primitive.h#1 - edit default
> change (text)

this one is just disturbing.  we have our own typedef of noreturn?  i
don't know what to say.

> //depot/cougar/nfx-tree/code/sm-libc/checksum.c#2 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/sm-libc/libc.h#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/sm-opt/fs.c#1 - edit default change

no ifdefs

> (text) //depot/cougar/nfx-tree/code/sm-opt/opt-api.c#1 - edit default
> change (text)

no ifdefs

> //depot/cougar/nfx-tree/code/sm-opt/opt-regm.c#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/sm-sct/sfmramdisk.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/sm-sct/taskmgr.c#1 - edit default change
> (text)

what's this 13 crap?  do you mean '\r'?.  who can maintain this?  not
me, i'm too stupid to know what 13 is all about.

> //depot/cougar/nfx-tree/code/sm-spm/spm-poll.c#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/sm-spm/spm-util.c#1 - edit default change
> (text)

is NEW_LABEL_SCHEME always defined?  then it should be ripped out.
these changes look fine but please rip out this macro.

> //depot/cougar/nfx-tree/code/sm-spm/spm.h#1 - edit default change

lose the macro

> (text) //depot/cougar/nfx-tree/code/sm-testdump/testdump-api.h#1 -
> edit default change (text)

ok

> //depot/cougar/nfx-tree/code/sm-utils/cmd-utils.c#1 - edit default
> change (xtext)

ok

> //depot/cougar/nfx-tree/code/sm-utils/cmd-utils.h#1 - edit default
> change (xtext)

no changes, please revert

> //depot/cougar/nfx-tree/code/ssc-authen-lib/authen-localaccounts-api.c#1
> - edit default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-authen-lib/privs-cfg.c#1 - edit
> default change (text)

portable?  i'm guessing yes but i have to ask

> //depot/cougar/nfx-tree/code/ssc-authentication/Makefile#1 - edit
> default change (text)

what happened to lic?  not portable (?)

> //depot/cougar/nfx-tree/code/ssc-authentication/auth-nis.c#1 - edit
> default change (text)

all ok except the ifndef linux -- this can be done in a portable way

> //depot/cougar/nfx-tree/code/ssc-authentication/authen-api.h#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-cluster/cluster-contrl-cache.c#1 -
> edit default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#1 - edit
> default change (text)

agck!  a million horrible ifdefs!

> //depot/cougar/nfx-tree/code/ssc-cluster/cluster-rmc.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-cluster/cluster-vol-api.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-cluster/cluster-vol-api.h#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-cluster/cluster-vsvr-api.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-cluster/cluster-vsvr-api.h#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-hostid/hostid.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-ndmp/ndmp-data.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-ndmp/ndmp-snap.c#1 - edit default
> change (text)

you can't break up into multiple lines?  borked macro then.

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxauth.c#1 - edit default
> change (text)

no ifdefs.  no ifndefs either.

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxdns-inlines.h#1 - edit
> default change (text)

no ifdefs no how

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxdns.c#1 - edit default
> change (text)

definitely not doing this.  no ifdefs like this.  i need to write a
cookbook so people know what to do.

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxldap.c#1 - edit default
> change (text)

no ifdefs

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-api.h#1 - edit default
> change (text)

no changes, please revert

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-dns.c#1 - edit default
> change (text)

lose the ifdef

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-lib.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-nis.c#1 - edit default
> change (text)

no ifdefs

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-res.c#1 - edit default
> change (text)

h_errno?? you're going to have to explain that one.
no ifdefs
2565 do the delorean boys know about this one?


> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-rpc.h#1 - edit default
> change (text)

i don't like the ifndef, really.  but i might be casual about this
one.  platform stuff like this should really be in separate files but...

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-yp.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis.c#1 - edit default
> change (text)

ifdef city.  additions of the casts look ok.  but not the ifdefs.

> //depot/cougar/nfx-tree/code/ssc-nfxnis/test/ldaptest.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-openafs-lwp/iomgr.c#1 - edit default
> change (text)

no changes, please revert

> //depot/cougar/nfx-tree/code/ssc-openafs-lwp/lwp.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-openafs-lwp/process.S#1 - edit
> default change (text)

no ifdefs

> //depot/cougar/nfx-tree/code/ssc-openafs-lwp/waitkey.c#1 - edit
> default change (text)

i assume the ifdef change is from the configure script, if so, ok.

> //depot/cougar/nfx-tree/code/ssc-openafs-rx/rx_getaddr.c#1 - edit
> default change (text)

ditto this ifdef

> //depot/cougar/nfx-tree/code/ssc-openafs-rx/xdr.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-openafs-rx/xdr_array.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-openafs-rx/xdr_refernce.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-openafs-ubik/beacon.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-openafs-ubik/disk.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-openafs-util/afs_param.h#1 - edit
> default change (text)

no ifdefs

> //depot/cougar/nfx-tree/code/ssc-openafs-util/afsconfig.h#1 - edit
> default change (text)

no ifdefs

> //depot/cougar/nfx-tree/code/ssc-openafs-util/serverLog.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-openafs-util/uuid.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-prom-upgrade/prom-upgrade.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-rcon/ssc-rcon.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-rconlib/rconlib.c#1 - edit default
> change (xtext)

ok

> //depot/cougar/nfx-tree/code/ssc-rmc/rmc.c#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/ssc-rmc/rmc_client.c#1 - edit default
> change (text)

no ifdefs, and besides, there is a portable way to do this

> //depot/cougar/nfx-tree/code/ssc-rmc/rmc_pm.c#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/ssc-rmc/rmc_ssc.h#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/ssc-stdio/stdiod.c#1 - edit default
> change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-sys-dvt/ssc-sys-dvt.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-timekeeper/timekeeper.c#1 - edit
> default change (text)

ok

> //depot/cougar/nfx-tree/code/ssc-vsd/vs-ipm.c#1 - edit default change
> (text)

no ifdefs, no siree

> //depot/cougar/nfx-tree/code/ssc-vtm/vtm-msg.c#1 - edit default change
> (text)

ok

> //depot/cougar/nfx-tree/code/ssc-vtm/vtm-util.c#1 - edit default
> change (text)
