AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081105101919.428784db@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB5175BE0AEE6@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 5 Nov 2008 10:19:50 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Maxim Kozlovsky <maxim.kozlovsky@onstor.com>
Subject: Re: please review 31050
Message-ID: <20081105101950.5ffbff92@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB5175BE0AEE6@exch1.onstor.net>
References: <20081104172051.614c5f3e@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB5175BE0AED2@exch1.onstor.net>
	<20081104172955.66d9d176@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB5175BE0AEE6@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

OK, I have made some additional changes which seems to take care of the
problem you mentioned.  I added some debug code to print out what the
handler is, and indeed it does get reset.  Somehow I missed it's use in
the exim_lock code.  The additional changes seem to fix that and the
debug code bears that out -- the rmc handler is properly in place when
rmc related code is called.  I've been running this version overnight
on my filer without problems.  Let me know what you think.

Stupid strlen thing removed.  I had it the other way around at first,
then got paranoid and changed it at the last second.  Duh.

The same directories have the additional changes:

Original code:

~andys/src/dev/linux/Pkgs/source/exim4/exim4-4.63-virgin/src

changed code:

~andys/src/r401rel/linux/Pkgs/source/exim4/exim4-4.63/src



On Tue, 4 Nov 2008 17:50:40 -0800 Maxim Kozlovsky
<maxim.kozlovsky@onstor.com> wrote:

> I don't think that this is the complete fix. In the instance of the
> exim4 I've looked at the signal handler was setup to the exim4 signal
> handler, instead of the RMC signal handler. The new code does nothing
> to change that.
> 
> Dns.c:458
> 
> This is a wrong way to compare strings. It will compare exim4-12345
> and exim4-1234 as equal. Use strcmp().
> 
> 
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Tuesday, November 04, 2008 5:30 PM
> >To: Maxim Kozlovsky
> >Subject: Re: please review 31050
> >
> >Hmm, let's see.  Original code:
> >
> >~andys/src/dev/linux/Pkgs/source/exim4/exim4-4.63-virgin
> >
> >new code:
> >
> >~andys/src/r401rel/linxu/Pkgs/source/exim4/exim4-4.63/build-tree/src
> >
> >
> >On Tue, 4 Nov 2008 17:24:24 -0800 Maxim Kozlovsky
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Can you make directories with old and new code so I can review the
> >> files instead of patch?
> >>
> >> >-----Original Message-----
> >> >From: Andy Sharp
> >> >Sent: Tuesday, November 04, 2008 5:21 PM
> >> >To: Maxim Kozlovsky
> >> >Subject: please review 31050
> >> >
> >> >Change 31050 by andys@ripper on 2008/11/04 16:52:56 *pending*
> >> >
> >> >        TED00025710 - [10206 - Onstor] Over 200 Exim processes
> >> > running
> >> >
> >> >        Rework the way rmc_init_ex() is called from exim, possibly
> >> > it was not too good the way it was.
> >> >
> >> >        Add a call to rmc_shutdown() after last call to an RMC
> >> > related function.  Just to be sure.
> >> >
> >> >        Re-implement milliwait() exim function to use nanosleep(2)
> >> > which does not use SIGALRM.  It was previously using setitimer(2)
> >> > which RMC also uses, and therefore the two could theoretically
> >> > conflict. However I could find no calls to milliwait() in the
> >> > execution path of exim that we would use so this is mostly for
> >> > completeness. Although just because I couldn't find one doesn't
> >> > mean there isn't one, or isn't one after the last RMC related
> >> > call, which is where I stopped looking.  And that could
> >> > potentially screw up RMC in certain circumstances so best to
> >> > just replace it.
> >> >
> >> >        regression: autosupport email
> >> >
> >> >        reviewed by
> >> >
> >> >Affected files ...
> >> >
> >> >... //depot/dev/linux/Pkgs/binary/Deb/exim4-base_4.63-17_mipsel.deb#6
> >> >edit ... //depot/dev/linux/Pkgs/binary/Deb/exim4-config_4.63-
> >17_all.deb#3
> >> >edit ... //depot/dev/linux/Pkgs/binary/Deb/exim4-daemon-custom_4.63-
> >> >17_mipsel.deb#7 edit
> >> >... //depot/dev/linux/Pkgs/source/exim4/onstor-vsvr-support.dpatch#3
> >> >edit
> >>
