AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070404101501.03cd327c@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E031DF2C9@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 4 Apr 2007 10:15:45 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20070404101545.7e87f813@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E031DF2C9@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E031DE995@onstor-exch02.onstor.net>
	<20070403195844.27526159@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E031DF2C9@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 4 Apr 2007 09:44:29 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Tuesday, April 03, 2007 7:59 PM
> > To: Maxim Kozlovsky
> > Subject: Re: Please review
> > 
> > On Mon, 2 Apr 2007 16:41:49 -0700 "Maxim Kozlovsky"
> > <maxim.kozlovsky@onstor.com> wrote:
> > 
> > >
> > > ~/cg/nfx-tree
> > >
> > > SSC compilation fixes, mostly one-liners. I've ifdefed out the
> places
> > > that do not compile or will not work on linux without substantial
> > > changes.
> > 
> > No ifdefs allowed.  Sole exception: ifdefs added by configure in
> > open source packages.
> > 
> > 
> *** I understand your sentiments about ifdefs, however I am not trying
> to fix it all in the first pass. I'd like to get most of the code
> compiling so we would be able split the work between more people and
> then do it in prettier way. 

I'm sticking to my guns.  This is how mountains of crappy code
get created. The go-back-later-and-fix it stuff doesn't fly because it
never happens. Just hold off for a day and I'll write up what I'm
thinking and you can tell me what you think of that.  But I'm not
accepting "we'll do a shitty job now and ..." on this project.
Somebody has to hold the line.

I don't see what the value of getting things to compile is.  That's
part of the work that people can do.

> > > //depot/cougar/nfx-tree/Includes/nfx-defs.h#2 - edit default
> > > change (text)
> > 
> > wong place for the protocol defs.  should be in one of the eee
> > header files.  one that will work in both user and kernel spaces.
> 
> Right, so tell me which one.

I'm just the reviewer, you're the programmer.

> > > //depot/cougar/nfx-tree/Includes/rpc/rpc.h#1 - edit default change
> > > (text)
> > 
> > no ifdefs
> > 
> See ***
> 
> > > //depot/cougar/nfx-tree/Includes/rpc/xdr.h#1 - edit default change
> > > (text)
> > 
> > no ifdefs
> 
> See ***
> > 
> > > //depot/cougar/nfx-tree/Makefile.ssc#1 - edit default change
> > > (text)
> > 
> 
> ok
> 
> > 
> > > //depot/cougar/nfx-tree/Tools/defs.mk#3 - edit default change
> > > (text)
> > 
> > no sync'd with repository
> > -Wno-pointer-sign -- are you sure??  we don't want our pointers sign
> > extended?  ok then, if you're sure.  just resolve first.
> 
> This is not pointer sign extension, this is a warning about conversion
> between (unsigned char *) and (char *) which is new in 4.1 gcc. We
> have too much code that has this problem.

We should probably just fix them, but OK.  I mean, if I can review a
hundred files, someone can fix these.  I'd almost rather turn off
-Werror for a while and gradually fix the warnings than turn off the
warnings.

> > > //depot/cougar/nfx-tree/Tools/suffix.mk#1 - edit default change
> (text)
> > 
> > changes don't look portable to me
> ok
> 
> > 
> > 
> > > //depot/cougar/nfx-tree/code/sm-cifs/winerror.h#1 - edit default
> > > change (xtext)
> > 
> > please put platform stuff in a separate file.  is this platform or
> > compiler thing?  or glibc thing?  a compiler thing can stay, but
> > not a glibc or platform thing.
> 
> Where is the platform stuff?

Good question.  Give me a couple of days.

> > > //depot/cougar/nfx-tree/code/sm-event/emrs-api.h#1 - edit default
> > > change (text)
> > 
> > lose the ifdefs
> 
> See ***
> > 
> > 
> > 
> > > //depot/cougar/nfx-tree/code/sm-fs/fs-primitive.h#1 - edit default
> > > change (text)
> > 
> > this one is just disturbing.  we have our own typedef of noreturn?
> > i don't know what to say.
> 
> Old gcc did not have noreturn. 
> > 
> > > //depot/cougar/nfx-tree/code/sm-opt/fs.c#1 - edit default change
> > 
> > no ifdefs
> 
> See ***
> > 
> > > (text) //depot/cougar/nfx-tree/code/sm-opt/opt-api.c#1 - edit
> default
> > > change (text)
> > 
> > no ifdefs
> 
> See ***
> > 
> > 
> > > //depot/cougar/nfx-tree/code/sm-sct/taskmgr.c#1 - edit default
> change
> > > (text)
> > 
> > what's this 13 crap?  do you mean '\r'?.  who can maintain this?
> > not me, i'm too stupid to know what 13 is all about.
> 
> Yeah, right, I can never remember those char codes. 

man ascii

> > > //depot/cougar/nfx-tree/code/ssc-authentication/Makefile#1 - edit
> > > default change (text)
> > 
> > what happened to lic?  not portable (?)
> 
> Is not used, does not compile, does not work. 

ok.

> > > //depot/cougar/nfx-tree/code/ssc-authentication/auth-nis.c#1 -
> > > edit default change (text)
> > 
> > all ok except the ifndef linux -- this can be done in a portable way
> > 
> What is the portable way?

Do I have to do everything?

> > > //depot/cougar/nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c#1 -
> edit
> > > default change (text)
> > 
> > agck!  a million horrible ifdefs!
> 
> See ***
> > 
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxauth.c#1 - edit default
> > > change (text)
> > 
> > no ifdefs.  no ifndefs either.
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxdns-inlines.h#1 - edit
> > > default change (text)
> > 
> > no ifdefs no how
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxdns.c#1 - edit default
> > > change (text)
> > 
> > definitely not doing this.  no ifdefs like this.  i need to write a
> > cookbook so people know what to do.
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxldap.c#1 - edit default
> > > change (text)
> > 
> > no ifdefs
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-api.h#1 - edit
> default
> > > change (text)
> > 
> > no changes, please revert
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-dns.c#1 - edit
> default
> > > change (text)
> > 
> > lose the ifdef
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-lib.c#1 - edit
> default
> > > change (text)
> > 
> > ok
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-nis.c#1 - edit
> default
> > > change (text)
> > 
> > no ifdefs
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-res.c#1 - edit
> default
> > > change (text)
> > 
> > h_errno?? you're going to have to explain that one.
> > no ifdefs
> > 2565 do the delorean boys know about this one?
> > 
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-rpc.h#1 - edit
> default
> > > change (text)
> > 
> > i don't like the ifndef, really.  but i might be casual about this
> > one.  platform stuff like this should really be in separate files
> but...
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis-yp.c#1 - edit
> > > default change (text)
> > 
> > ok
> > 
> > > //depot/cougar/nfx-tree/code/ssc-nfxnis/nfxnis.c#1 - edit default
> > > change (text)
> > 
> > ifdef city.  additions of the casts look ok.  but not the ifdefs.
> 
> 
> See *** for all the above. This code needs to be extensively modified
> and it is not possible to fix it all at once.

Yes, it is.  Or rather I should say, it is possible to fix it all.  One
at a time, however.
 
> > > //depot/cougar/nfx-tree/code/ssc-openafs-lwp/process.S#1 - edit
> > > default change (text)
> > 
> > no ifdefs
> 
> See ***
> > 
> > 
> > > //depot/cougar/nfx-tree/code/ssc-rmc/rmc_client.c#1 - edit default
> > > change (text)
> > 
> > no ifdefs, and besides, there is a portable way to do this
> > 
> What is it?

I thought you were the brilliant programmer.  I don't even know what
read-copy-modify is.
 
> > > //depot/cougar/nfx-tree/code/ssc-vsd/vs-ipm.c#1 - edit default
> change
> > > (text)
> > 
> > no ifdefs, no siree
> 
> See ***
> 
