AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081113105324.785989d5@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<a.zummo@towertech.it>,<rtc-linux@googlegroups.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	20081113173156.19815.10575.stgit@i1501.lan.towertech.it
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 13 Nov 2008 10:54:57 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Alessandro Zummo <a.zummo@towertech.it>
Cc: "rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>
Subject: Re: [RFC PATCH] rtc: rtc-ds1511 misc fixes
Message-ID: <20081113105457.1c120844@ripper.onstor.net>
In-Reply-To: <20081113173156.19815.10575.stgit@i1501.lan.towertech.it>
References: <20081113173156.19815.10575.stgit@i1501.lan.towertech.it>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 13 Nov 2008 09:31:56 -0800 Alessandro Zummo
<a.zummo@towertech.it> wrote:

> - implemented rtc_irq_set_state
> - use platform_driver_probe
> - fixed probe/remove sequence
> - fixed style issues
> - this patch requires the latest rtc alarm/update patch
> available in -mm
> 
> Please provide a Tested-by
> 
> Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Andrew Sharp <andy.sharp@onstor.com>
> ---
> 
>  drivers/rtc/rtc-ds1511.c |  341
> +++++++++++++++++++++------------------------- 1 files changed, 157
> insertions(+), 184 deletions(-)

The large amount of style changes [not all of which are for the better]
interfere with my ability to gage the logic changes.  Any chance you
could split into two patches?