AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081113144824.5ac16e26@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<alessandro.zummo@towertech.it>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	20081113233001.4137bbd4@i1501.lan.towertech.it
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 13 Nov 2008 14:49:49 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [rtc-linux] Re: [RFC PATCH] rtc: rtc-ds1511 misc fixes
Message-ID: <20081113144949.414fd7ec@ripper.onstor.net>
In-Reply-To: <20081113233001.4137bbd4@i1501.lan.towertech.it>
References: <20081113173156.19815.10575.stgit@i1501.lan.towertech.it>
	<20081113105457.1c120844@ripper.onstor.net>
	<20081113233001.4137bbd4@i1501.lan.towertech.it>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 13 Nov 2008 14:30:01 -0800 Alessandro Zummo
<alessandro.zummo@towertech.it> wrote:

> On Thu, 13 Nov 2008 10:54:57 -0800
> Andrew Sharp <andy.sharp@onstor.com> wrote:
> 
> > The large amount of style changes [not all of which are for the
> > better] interfere with my ability to gage the logic changes.  Any
> > chance you could split into two patches?
> 
>  Sure, I'll send it in a couple of days.
>  I'm trying to implement the CodingStyle guidelines for all
>  the rtc drivers. If there's something I did wrong, please feel free
> to report it to me.

Well, my ass was chaffing over the change to the comment style, I
thought the original was the official kernel style.  I realize the
elimination of curly braces on code blocks of just one line is accepted
kernel standard, but that doesn't stop me from disliking it -- I feel
having the braces makes for a less hazardous maintenance environment.
But then again I can't win all the battles.

Usually people ask for style/whitespace changes to be in a separate
patch.  I always sort of wondered why until now.   It can be hard to
focus on the logic changes which are the most important.  Also, if
someone doesn't like the style/whitespace changes, it's easier to just
say "go ahead" and not even look at the patch, but you can't really do
that with logic changes ~:^)

Cheers,

a

