AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081119143945.7706dc2f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB5175D6201E7@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 19 Nov 2008 14:39:59 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: please review 31045
Message-ID: <20081119143959.2e2faaba@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB5175D6201E7@exch1.onstor.net>
References: <20081119142650.36c86697@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB5175D6201E7@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Integrated into r401rel, so you have a 'go'

Thanks,

a

On Wed, 19 Nov 2008 14:27:52 -0800 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Looks good.
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, November 19, 2008 2:27 PM
> To: Larry Scheer
> Subject: Re: please review 31045
> 
> On Wed, 19 Nov 2008 14:23:40 -0800 Larry Scheer
> <larry.scheer@onstor.com> wrote:
> 
> > linux/rootfs/etc/logrotate.d/onstor
> > 
> >      Line 14: Please let's not call our own product names in
> > production code. Even if it is true, we should keep our discontent
> > out of the eyes of customers, CEs, and SEs. Change the comment to
> >      something polite.
> 
> fixed
> 
> > nfx-tree/code/ssc-cfmond/cfmond-elog-test.c
> > 
> >      >>add nfx-tree/code/ssc-cfmond/cfmond-elog-test.c
> > 
> > nfx-tree/code/ssc-cfmond/cfmond.sh
> > 
> >      looks good
> > 
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Wednesday, November 19, 2008 2:03 PM
> > To: Larry Scheer
> > Subject: please review 31045
> > 
> > Change 31045 by andys@ripper on 2008/11/04 15:52:10 *pending*
> > 
> >         TED00025452 - /var got full last night at partner site
> >         
> >         Someone who shall remain nameless, I'll just mention the
> > initials
> >         - IAN BROWN - screwed up the /etc/logrotate.d/onstor file so
> >         that it no longer rotates a file that is too big, making it
> > so that /var can fill up.
> >         
> >         Add size back in as a factor for rotating the elog file.
> >         The size only gets invoked if cfmond is trying a logrotate
> > to try and shrink the used space in /var.
> >         
> >         Make some tweaks to cfmod.
> >         
> >         Change the minimum freed to declare victory to 2x the
> > requested minimum free, rather than 10x.  The default minimum free
> > for /var is now 10MB from 2MB, so 10x wasn't reasonable any more.
> >         
> >         Spruce up the elog information to be more, well,
> > informational. 
> >         Add unit test that fills the elog file to bursting /var in
> > less than 24 hours.  Use carefully.
> >         
> >         reviewed by
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-cfmond/cfmond-elog-test.c#1 add
> > ... //depot/dev/nfx-tree/code/ssc-cfmond/cfmond.sh#3 edit
> > 
