AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081126133650.68a893b9@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB5175D6201F6@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 26 Nov 2008 13:39:02 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: please review 31272
Message-ID: <20081126133902.2107d0b4@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB5175D6201F6@exch1.onstor.net>
References: <20081125103957.3efc900e@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB5175D6201F6@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 25 Nov 2008 15:29:49 -0800 Larry Scheer
<larry.scheer@onstor.com> wrote:

> nfx-tree/code/ssc-nfxsh/verify_install.in
> 
>      I can think of a scenario or two that would thwart your
> algorithm, however the probabilities are low.
> 
>      For instance what if the hosts file has an entry:
> 
>      IPADDR host.sc0 aliashost.sc0 host
> 
>      or
> 
>      IPADDR host.sc0 aliashost.sc0
> 
>      or
> 
>      IPADDR host.sc0
> 
>      Again all of these entries would need to be hand crafted but that
>      possibility exists.
> 
>      Lines 1236 - 1239 Not sure why you can't just write:
>         echo -e "$IPADDR\t$H2 $H1 $RESTO" >>/tmp/hosties.
>      But I trust your reasons for doing what you did. For my own
>      education I want to know why line 1237 - 1239 are needed.

I don't know what my brain was thinking when I wrote that.  Fixed.  In
fact, I changed that section even more: it was adding tabs after the
first word in a comment line.

And you missed the mis-spelling of CF_DIR on line 1250  ~:^)

>      I haven't given it a great deal of thought, but I would have used
>      a sed script to conditionally rewrite the hosts file. Perhaps
>      there is a subtle detail I am missing. But my sense is sed
>      would swap H2 and H1 more efficiently and would result in logic
>      that is more algorithmically correct, once you have the regular
>      expression figured out. Again I haven't given it a great deal of
>      thought though.
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, November 25, 2008 10:40 AM
> To: Larry Scheer
> Subject: please review 31272
> 
> Change 31272 by andys@ripper on 2008/11/25 10:38:44 *pending*
> 
>         Fix format of /etc/hosts files of 4.0.0 during upgrade.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#10 edit
> 
