AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20081212143341.0247809f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB5175D620226@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 12 Dec 2008 14:33:57 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Please review change 31428
Message-ID: <20081212143357.75e58910@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB5175D620226@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB5175D620226@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 11 Dec 2008 17:54:38 -0800 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Andy,
>   This change should have been made for the cougar project it never
> got in. It was a task I gave Ken R that he never did. I finally have
> gotten around to doing it myself, once I remembered it needed to be
> done.
> 
> For builds I have been creating a tree-name file to set the version,
> it is an option that has been there for years but you need to have a
> script to create it or build it by hand. This change allows
> developers to do a build without a tree name file and get the version
> string set correctly for bobcats and cougars. This fixes an irritant
> that has been there since the cougar's release number diverged from
> the bobcats.
> 
> Again these changes are in my linux compile workspace mounted on
> ripper: /home/larrys/perforce/trees/dev/nfx-tree
> 
> 
> Change 31428 by larrys@larrys-r14-dmip on 2008/12/10 19:24:14
> *pending*
> 
>         Create the correct version string when tree-name
>         doesn't exist. Use the Tools/version-$PROD file so each
>         product build has the correct version string.
>         Reviewed by:
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/Makefile#15 edit
> ... //depot/dev/nfx-tree/Tools/create_version.pl#1 edit



= Change 31428 by larrys@larrys-r14-dmip on 2008/12/10 19:24:14
*pending* = 
= 	Create the correct version string when tree-name
= 	doesn't exist. Use the Tools/version-$PROD file so each
= 	product build has the correct version string.
= 	Reviewed by:
= 

Doesn't it always create the version string regardless of tree-name
file existence?


nfx-tree/Makefile

     more special crapola for test.  what good does a variable do if
     you can't use it?  mumble-grumble.

nfx-tree/Tools/create_version.pl

     looks pretty basic.  more special handling for PROD=test...

OK