AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090106151405.77691149@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>,<Ram.Upendran@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB5176334C226@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 6 Jan 2009 15:14:57 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ed Kwan <ed.kwan@onstor.com>
Cc: Ram Upendran <Ram.Upendran@onstor.com>
Subject: Re: PERFORCE change 31578 for review
Message-ID: <20090106151457.53dc7659@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB5176334C226@exch1.onstor.net>
References: <WEBMAILXJyXDbMS7Xko00000006@mail.onstor.com>
	<20090106141342.31f5a480@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB5176334C226@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

In general, not necessary to go back and change it.  It's more of a
long term cumulative thing than an individual checkin thing.

Part of code/checkin review is supposed to be a review of the checkin
comment as well, so I'd like to gently nudge folks into picking up that
habit as well.

Thanks,

a


On Tue, 6 Jan 2009 14:47:56 -0800 Ed Kwan <ed.kwan@onstor.com> wrote:

> Ram and I already discussed this, and he will follow the standard
> convention from now on.  Per Larry, Ram should be able to go back and
> change the descriptions.
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, January 06, 2009 2:14 PM
> To: Ram Upendran
> Cc: Ed Kwan
> Subject: Re: PERFORCE change 31578 for review
> 
> On Tue, 6 Jan 2009 13:55:01 -0800 Ram Upendran
> <Ram.Upendran@onstor.com> wrote:
> 
> > Change 31578 by rupendran@ram2 on 2009/01/06 13:50:02
> > 
> > 	TED00025477 Filer crashed with panic during restore - SF
> > case 8712 and 9852 reviewed by edkwan
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/code/sm-sdm-agent/sdm-agent.c#4 edit
> 
> Come on guys -- what was the change?  Also, I noticed this change went
> into r332rel first.  Was it done separately in each branch for a
> reason?  It would also be nice to know from the checkin description
> why it's gone (going?) into some branches and not others.
> 
> Thanks,
> 
> a
