AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB51851A8511B@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 23 Jan 2009 17:19:09 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: please review changes to nightly build script change 31743
Message-ID: <20090123171909.664a21ea@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB51851A8511B@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB51851A8511B@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 23 Jan 2009 12:45:13 -0800 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Workspace is compile3:/perforce/trees/cm/build_scripts/buildver
> 
> Change 31743 by larrys@build-depot on 2009/01/22 14:34:50 *pending*
> 
>         Updates to the nightly build script.
>         - Changes to build on a system other than k2.
>         - Added build of test binaries ( make test )
>         - Turned off build of Cheetah BSD kernel.
>         - Cleaned up inefficient computation of date strings.
>         - Removed unused variables.
>         Reviewed by: AndyS
> 
> Affected files ...
> 
> ... //depot/cm/build_scripts/buildver/nfxbuild.sh#50 edit


= Change 31743 by larrys@build-depot on 2009/01/22 14:34:50 *pending*
= 
= 	Updates to the nightly build script.
= 	- Changes to build on a system other than k2. 
= 	- Added build of test binaries ( make test )
= 	- Turned off build of Cheetah BSD kernel.

Actually you turned it on, it looks to me.

= 	- Cleaned up inefficient computation of date strings.
= 	- Removed unused variables.
= 	Reviewed by: AndyS
= 

build_scripts/buildver/nfxbuild.sh

     line 43, pfft, just make it build-depot, don't you think?  do we
     need build-k3-depot?  and definitely trash build-k2-depot since
     this all runs fine on c3pio, oops, i mean compile3

     line 141, huh? bsd-ch-kernel.log?  we don't do anything for
     ch anymore

     line 361, finally, some actual PROGRAMMING

     line 418, what is all this changing the bobcat kernel build to
     cheetah?  it was working fine as bobcat, why would you want to
     change it to cheetah?  that just means we have to maintain all
     these macros and whatnot for cheetah values.

     line 710, this isn't execute per VARIANT, only per PROD, so this
     will always fail, so it's just confusing to have it there.



