AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB51851A85165@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 2 Feb 2009 17:46:47 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Please review Sripal's change 30071
Message-ID: <20090202174647.012091a4@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB51851A85165@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB51851A85165@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 2 Feb 2009 17:30:58 -0800 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Andy,
>    I looked at this change and it appears to be the correct thing to
> do. What do you think?
> 
> I can check in sripals fixes.
> 
> Change 30071 by sripal@sripal-rdev on 2008/07/17 07:02:25 *pending*
> 
>         TED00024761 Cougar:System upgrade without timezone configured
> will lead to empty /etc/localtime file.
> 
>         Now booting to CF after flash install will have US/Pacific as
>         default timezone (same as BSD).
>         Added default timezone files to rootfs.
> 
>         Handled timezone file corruption for Cougar during upgrade.
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/Makefile#42 edit
> ... //depot/dev/linux/rootfs/etc/localtime#1 add
> ... //depot/dev/linux/rootfs/etc/timezone#1 add
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#12 edit



= Change 30071 by sripal@sripal-rdev on 2008/07/17 07:02:25 *pending*
= 
= 	TED00024761 Cougar:System upgrade without timezone configured
will lead = 	       to empty /etc/localtime file.
= 	
= 	Now booting to CF after flash install will have US/Pacific as
= 	default timezone (same as BSD).
= 	Added default timezone files to rootfs.
= 	
= 	Handled timezone file corruption for Cougar during upgrade.


linux/rootfs/Makefile

     uh, why would these be in our rootfs makefile?
	 it should be impossible to configure w/o timezone configured

linux/rootfs/etc/localtime

     >>add linux/rootfs/etc/localtime

	 no, see above

linux/rootfs/etc/timezone

     >>add linux/rootfs/etc/timezone

	 no, see above

nfx-tree/code/ssc-nfxsh/verify_install.in

     line 1222, the timezone thing should be moved under the localtime
     thing for Linux in the case statement above.

