AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090202192434.15769ea6@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB51851A85168@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 2 Feb 2009 19:24:48 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Please review LDAP package changes 31769
Message-ID: <20090202192448.4cffb0c8@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB51851A85168@exch1.onstor.net>
References: <20090202175223.794825ad@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB51851A85168@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 2 Feb 2009 18:02:53 -0800 Larry Scheer
<larry.scheer@onstor.com> wrote:

> See below...
> 
> 
> 
> -----Original Message-----
> From: Andy Sharp
> Sent: Monday, February 02, 2009 5:52 PM
> To: Larry Scheer
> Subject: Re: Please review LDAP package changes 31769
> 
> 
> 
> On Mon, 2 Feb 2009 15:56:07 -0800 Larry Scheer
> 
> <larry.scheer@onstor.com> wrote:
> 
> 
> 
> > Andy,
> 
> >    These are on my Mightdog workspace: /homes/larrys/src/dev
> 
> >
> 
> > Change 31769 by larrys@larrys on 2009/01/26 13:55:18 *pending*
> 
> >
> 
> >         Updates for ONStor changes to OpenLDAP source code. Build
> > new
> 
> > LDAP packages.
> 
> >
> 
> >         Fix for the defect TED00025696 9732-UMIACS] LDAP server
> 
> > designation does not allow more than 3 servers in config
> 
> >
> 
> >         Add Ron B's changes for vanilla Samba 3.0.32
> 
> >         Reviewed by: AndyS
> 
> >
> 
> > Affected files ...
> 
> >
> 
> > ... //depot/dev/linux/Pkgs/binary/Deb/libldap-2.3-0-mipsel-cross_2.3.30-5+etch2_all.deb#1
> 
> > add ... //depot/dev/linux/Pkgs/binary/Deb/libldap-2.3-0_2.3.30-5+etch2_mipsel.deb#1
> 
> > add ... //depot/dev/linux/Pkgs/binary/Rpm/libldap-2.3-0-mipsel-cross-2.3.30-6.noarch.rpm#1
> 
> > add ... //depot/dev/linux/Pkgs/source/openldap2/onstor-src.dpatch#1
> 
> > edit
> 
> >
> 
> 
> 
> 
> 
> 
> 
> 
> 
> = Change 31769 by larrys@larrys on 2009/01/26 13:55:18 *pending*
> 
> =
> 
> =     Updates for ONStor changes to OpenLDAP source code. Build new
> 
> LDAP =      packages.
> 
> =
> 
> =     Fix for the defect TED00025696 9732-UMIACS] LDAP server
> 
> designation does =      not allow more than 3 servers in config
> 
> =
> 
> =     Add Ron B's changes for vanilla Samba 3.0.32
> 
> =     Reviewed by: AndyS
> 
> =
> 
> 
> 
> The changes mentioned above are not in this changelist.  The only
> 
> changes are a handful of calls to syslog added.
> 
> 
> 
> LCS: Yes they are. The fix for TED 25696 is in onstor-src.dpatch line
> 468-469
> 
>       Compare this with kumarv's change 31146
> 
> 
> 
> This is for file: libraries/libldap/options.c
> 
> 
> 
> +        pInfo->nextOffset = (char *)pInfo - (char *)(*ppInfo) +
> infoSize;
> 
> +        pInfo = (char*)pInfo + infoSize;

p4 diff gives me this:


> +++ ../../../src/openldap-2.3.30/libraries/libldap/options.c  2008-11-10 20:31:24.000000000 -0800
468c468
< +        pInfo->nextOffset = pInfo - *ppInfo + infoSize;
---
> +        pInfo->nextOffset = (char *)pInfo - (char *)(*ppInfo) + infoSize;
495,496c495,504
< +++ ../../../src/openldap-2.3.30/libraries/libldap/os-ip.c    2007-04-05 16:58:38.000000000 -0700

which seems to just add a couple of type conversions which probably
aren't terribly necessary.  Unless it's causing some bug without them.



> 
> 
> 
> linux/Pkgs/binary/Deb/libldap-2.3-0-mipsel-cross_2.3.30-5+etch2_all.deb
> 
> 
> 
>      >>add
> 
>      linux/Pkgs/binary/Deb/libldap-2.3-0-mipsel-cross_2.3.30-5+etch2_all.deb
> 
> 
> 
> linux/Pkgs/binary/Deb/libldap-2.3-0_2.3.30-5+etch2_mipsel.deb
> 
> 
> 
>      >>add
>      >>linux/Pkgs/binary/Deb/libldap-2.3-0_2.3.30-5+etch2_mipsel.deb
> 
> 
> 
> linux/Pkgs/binary/Rpm/libldap-2.3-0-mipsel-cross-2.3.30-6.noarch.rpm
> 
> 
> 
>      >>add
> 
>      linux/Pkgs/binary/Rpm/libldap-2.3-0-mipsel-cross-2.3.30-6.noarch.rpm
> 
> 
> 
> linux/Pkgs/source/openldap2/onstor-src.dpatch
> 
> 
> 
>      ok, i guess, just a couple of syslog calls added.
> 
> 
