AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090203164635.0a813b1b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:exch1.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB51851A8516F@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 3 Feb 2009 16:46:36 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Please review change 31839 slightly different from Sripal's fix
 for the timezone defect.
Message-ID: <20090203164636.006e6737@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB51851A8516F@exch1.onstor.net>
References: <20090203140834.68e975d6@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB51851A8516F@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

looks good

On Tue, 3 Feb 2009 15:30:08 -0800 Larry Scheer
<larry.scheer@onstor.com> wrote:

> I thought the separate checks would make the logic easier to read and
> follow. I guess I was wrong about that.
> 
> Two checks on Linux need to be done, one for /etc/localtime one
> for /etc/timezone. If either one is missing both need to be reset to
> the default value of PST/PDT. We need to have both files in agreement
> with each other.
> 
> 
> 
> I can see a case where one exists but the other is missing. If we
> upgrade one to PST/PDT and the other is set to some other time zone
> that could create problems or at least make for a confusing situation.
> 
> 
> 
> As it turns out I need to do this check before the verify sum
> functions are run otherwise system upgrade reports:
> 
> The following files need upgrading:
> 
> 
> 
> ./usr/share/zoneinfo/localtime
> 
> ./usr/share/zoneinfo/localtime
> 
> 
> 
> So I re-wrote the logic into a single if block and moved this check
> above line 1178 (verify_sums $FLIST)
> 
> 
> 
> BTW: BSD doesn't have /etc/timezone so no check on this file is
> needed.
> 
> 
> 
> Let me know what you think.
> 
> 
> 
> Larry
> 
> 
> 
> 
> 
> -----Original Message-----
> From: Andy Sharp
> Sent: Tuesday, February 03, 2009 2:09 PM
> To: Larry Scheer
> Subject: Re: Please review change 31839 slightly different from
> Sripal's fix for the timezone defect.
> 
> 
> 
> On Tue, 3 Feb 2009 12:34:06 -0800 Larry Scheer
> 
> <larry.scheer@onstor.com> wrote:
> 
> 
> 
> > Andy,
> 
> >     This is on my /home/larrys/perforce/trees/dev workspace mounted
> 
> > on ripper.
> 
> >
> 
> > Change 31839 by larrys@larrys-r14-dmip on 2009/02/03 11:55:51
> 
> > *pending*
> 
> >
> 
> >         Fix for TED00024761 Cougar:System upgrade without timezone
> 
> > configured will lead to empty /etc/localtime file
> 
> >
> 
> >         Create /etc/timezone if it is missing at upgrade time for
> 
> > Cougar platform.
> 
> >
> 
> > Affected files ...
> 
> >
> 
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#12 edit
> 
> >
> 
> 
> 
> 
> 
> 
> 
> 
> 
> = Change 31839 by larrys@larrys-r14-dmip on 2009/02/03 11:55:51
> 
> *pending* =
> 
> =     Fix for TED00024761 Cougar:System upgrade without timezone
> 
> configured =      will lead to empty /etc/localtime file
> 
> =
> 
> =     Create /etc/timezone if it is missing at upgrade time for
> 
> Cougar platform. =
> 
> 
> 
> nfx-tree/code/ssc-nfxsh/verify_install.in
> 
> 
> 
>      line 1219-1227 seems to be duplicate of lines 1207-1212, execpt
> 
>      one checks for localtime and one checks for timezone
> 
> 
