AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070409164912.300b1f2b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E02215715@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 9 Apr 2007 16:49:43 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Code review request
Message-ID: <20070409164943.2d7c4f6b@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02215715@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E02215715@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 9 Apr 2007 14:34:36 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>    When you have a moment can you review the following files. They are
> in my home dir so you should have access to them.
> 
> Script to create cross packages and comvert them to rpms:
> 	
> /homes/larrys/perforce/trees/cougar/linux/pkg-tools/deb2cross2rpm

I don't know if it works, but it looks OK. I think if you invoke it
without arguments it just silently exits, but it that's what you want
it to do, then that's OK too.

> Global makefiles
> 	
> /homes/larrys/perforce/trees/cougar/nfx-tree/Tools/defs.mk

I don't think this is ready yet.  We should sit down and discuss the
overall plan for the Makefiles and includes and stuff.  I just want to
hear what you have in mind and so forth.  I'm not clear on where this
file fits in and at what stages and so forth.  And I'm not too thrilled
with the massive number of ifdefs (ifeqs in makefiles).

> /homes/larrys/perforce/trees/cougar/nfx-tree/Tools/tool-chain-pkg.mk

Fill in the first TODO ~:^)

I think you're getting there, or maybe you're already there, but let's
sit down (stand up?) tomorrow and you can run me through this stuff a
little bit before you check it in if that's OK.  Tomorrow morning is
fine if that works for you. Maybe grab a room with a whiteboard.

Line 59 has trailing whitespace.

I just want to make sure that I understand the large strokes of the
overall flow of the design, and what stage we think we're in and what
direction we're going to be going in as things progress.

Cheers,

a
