AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090310173655.5cec81c1@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AC7422FD1@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 10 Mar 2009 17:37:53 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: Please review 31958 glibc source update
Message-ID: <20090310173753.7e72a501@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AC7422FD1@exch1.onstor.net>
References: <20090304162329.3fbf64a9@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB52AC7422FD1@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


= Change 31958 by larrys@larrys on 2009/02/19 15:01:29 *pending*
= 
= 	Update GlibC source code to Etch version 2.3.6.ds1-13etch9.
= 	These file contain the Debian security patches and other
= 	changes to create the latest release of libc for Debian 4.0
(etch.) =
=	Add mkpatch.sh and onstor-src.patch to help with future
updates. = 	Reviewed by: AndyS
= 


One thing is missing.  OK, several things.  The actual built packages
themselves should be part of this changelist.  The .debs and rpms and
whatnot.  Nothing to read below here.




linux/src/glibc-2.3.6.ds1/debian/changelog

     looks good

linux/src/glibc-2.3.6.ds1/debian/control.in/main

     looks good

linux/src/glibc-2.3.6.ds1/debian/local/manpages/gencat.1

     looks good

linux/src/glibc-2.3.6.ds1/debian/local/manpages/iconvconfig.8

     looks good

linux/src/glibc-2.3.6.ds1/debian/local/manpages/mtrace.1

     looks good

linux/src/glibc-2.3.6.ds1/debian/patches/alpha/local-waitpid-not-cancel.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/alpha/local-waitpid-not-cancel.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-getnetgrent_r-memory-leak.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-getnetgrent_r-memory-leak.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nscd-free.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nscd-free.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nscd-hstcache.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nscd-hstcache.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nss_nis_setnetgrent.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nss_nis_setnetgrent.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-sunrpc-64bits-svc_getreqset.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-sunrpc-64bits-svc_getreqset.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-sunrpc_rpc_thread.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-sunrpc_rpc_thread.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-tls-link.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-tls-link.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-vfprintf-stack-smashing.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-vfprintf-stack-smashing.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-vfscanf.diff

     >>add linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-vfscanf.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/submitted-gethostbyname_r.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/any/submitted-gethostbyname_r.diff

linux/src/glibc-2.3.6.ds1/debian/patches/any/submitted-nis-netgrp.diff

     looks good

linux/src/glibc-2.3.6.ds1/debian/patches/localedata/sk_SK_euro.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/localedata/sk_SK_euro.diff

linux/src/glibc-2.3.6.ds1/debian/patches/localedata/sl_SI_euro.diff

     >>add
     linux/src/glibc-2.3.6.ds1/debian/patches/localedata/sl_SI_euro.diff

linux/src/glibc-2.3.6.ds1/debian/patches/series

     looks good

linux/src/glibc-2.3.6.ds1/debian/rules.d/build.mk

     looks good

linux/src/glibc-2.3.6.ds1/debian/rules.d/debhelper.mk

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/Makerules

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/BRF

     >>add linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/BRF

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/BRF..UTF-8

     >>add
     linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/BRF..UTF-8

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/alfabeta..UTF-16.BE

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/inet/getnetgrent_r.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/be_BY%40latin

     >>add
     linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/be_BY%40latin

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/ca_ES%40valencia

     >>add
     linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/ca_ES%40valencia

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/eu_FR%40euro

     >>add
     linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/eu_FR%40euro

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/sk_SK

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/sl_SI

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nis/nss_nis/nis-netgrp.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nscd/hstcache.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nscd/nscd_getpw_r.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/resolv/nss_dns/dns-host.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/stdio-common/vfprintf.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/stdio-common/vfscanf.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/sunrpc/rpc_thread.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/sunrpc/svc.c

     looks good

linux/src/glibc-2.3.6.ds1/glibc-2.3.6/sysdeps/unix/sysv/linux/not-cancel.h

     looks good

linux/src/glibc-2.3.6.ds1/mkpatch.sh

     >>add linux/src/glibc-2.3.6.ds1/mkpatch.sh

linux/src/glibc-2.3.6.ds1/onstor-src.patch

     >>add linux/src/glibc-2.3.6.ds1/onstor-src.patch



On Tue, 10 Mar 2009 14:09:44 -0700 Larry Scheer
<larry.scheer@onstor.com> wrote:

> Andy,
>    Take a look at my comments below. Unless I hear back from you
> before I leave today I will assume it is ok with you to submit this
> change list.
> 
> Thanks,
> 
> Larry
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, March 04, 2009 4:23 PM
> To: Larry Scheer
> Subject: Re: Please review 31958 glibc source update
> 
> = Change 31958 by larrys@larrys on 2009/02/19 15:01:29 *pending*
> = 
> =       Update GlibC source code to Etch version 2.3.6.ds1-13etch9.
> =       These file contain the Debian security patches and other
> =       changes to create the latest release of libc for Debian 4.0
> (etch.) =       Reviewed by: AndyS
> = 
> 
> 
> You should make the change in cl# to file
> 
> glibc-2.3.6/sunrpc/clnt_udp.c
> 
> into a dpatch.  If that wouldn't be too much work, can you add that
> to this?
> 
> [LCS]
> Actually yes it would be a good deal of work. See the next comment
> for details. However, I just added mkpatch.sh and onstor-src.patch to
> the change list to remind me what was done and to help with future
> Debian releases.
> 
> /homes/larrys/src/dev/linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nis/nss_nis/nis-netgrp.c
> /homes/larrys/src/dev/linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nscd/hstcache.c
> These changes shouldn't be necessary since you've included the
> dpatches that adds this change. ?  Maybe some others as well?
> 
> [LCS]
> Dpatch is not being run as part of "our" build process.
> These patches are applied with quilt in a special patch rule as part
> of the glibc build. Quilt wasn't/isn't on all developers systems that
> want to update glibc. Quilt and some of its dependent packages won't
> install on all Red Hat systems. Also the patch process was not
> reliable on non Debian systems. I needed to provide a workaround for
> the patch rules. Part of the workaround is to check in the updated
> source such as the ones you pointed out.  Is this harder than just
> using the patch process? Perhaps, for you and me who are used to
> using patch and dpkg-buildpackage. But for other developers who
> want/need to use there own build systems and are not familiar with
> Debian's/OpenSource methods, having the patched code checked in for
> them is much easier to work with and understand.
> 
> linux/src/glibc-2.3.6.ds1/debian/changelog
>                                 
>      line 5, extra space after < in max's email is bad, must remove
> [LCS] Fixed
> 
>                                 
> linux/src/glibc-2.3.6.ds1/debian/control.in/main
>                                 
>      looks good                 
>                                 
> linux/src/glibc-2.3.6.ds1/debian/local/manpages/gencat.1
>                                 
>      looks good                 
>                                 
> linux/src/glibc-2.3.6.ds1/debian/local/manpages/iconvconfig.8
>                                 
>      looks good                 
>                                 
> linux/src/glibc-2.3.6.ds1/debian/local/manpages/mtrace.1
>                                 
>      looks good                 
>                                 
> linux/src/glibc-2.3.6.ds1/debian/patches/alpha/local-waitpid-not-cancel.diff
>                                 
>      >>add                      
>      linux/src/glibc-2.3.6.ds1/debian/patches/alpha/local-waitpid-not-cancel.diff
>                                 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-getnetgrent_r-memory-leak.diff
>                                 
>      >>add                      
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-getnetgrent_r-memory-leak.diff
>                                 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nscd-free.diff
>                                 
>      >>add                      
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nscd-free.diff
>                                 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nscd-hstcache.diff
>                                 
>      >>add                      
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nscd-hstcache.diff
>                                 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nss_nis_setnetgrent.diff
>                                 
>      >>add                      
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-nss_nis_setnetgrent.diff
>                                 
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-sunrpc-64bits-svc_getreqset.diff
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-sunrpc-64bits-svc_getreqset.diff
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-sunrpc_rpc_thread.diff
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-sunrpc_rpc_thread.diff
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-tls-link.diff
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-tls-link.diff
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-vfprintf-stack-smashing.diff
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-vfprintf-stack-smashing.diff
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-vfscanf.diff
> 
>      >>add
>      >>linux/src/glibc-2.3.6.ds1/debian/patches/any/cvs-vfscanf.diff
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/submitted-gethostbyname_r.diff
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/debian/patches/any/submitted-gethostbyname_r.diff
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/any/submitted-nis-netgrp.diff
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/localedata/sk_SK_euro.diff
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/debian/patches/localedata/sk_SK_euro.diff
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/localedata/sl_SI_euro.diff
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/debian/patches/localedata/sl_SI_euro.diff
> 
> linux/src/glibc-2.3.6.ds1/debian/patches/series
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/debian/rules.d/build.mk
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/debian/rules.d/debhelper.mk
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/Makerules
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/BRF
> 
>      >>add
>      >>linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/BRF
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/BRF..UTF-8
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/BRF..UTF-8
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/iconvdata/testdata/alfabeta..UTF-16.BE
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/inet/getnetgrent_r.c
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/be_BY%40latin
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/be_BY%40latin
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/ca_ES%40valencia
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/ca_ES%40valencia
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/eu_FR%40euro
> 
>      >>add
>      linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/eu_FR%40euro
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/sk_SK
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/localedata/locales/sl_SI
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nis/nss_nis/nis-netgrp.c
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nscd/hstcache.c
> 
>      not necessary because dpatch that performs this change you added
>      already.  yes?
> [LCS] See previous comment.
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/nscd/nscd_getpw_r.c
> 
>      ditto for this one?
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/resolv/nss_dns/dns-host.c
> 
>      ditto?
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/stdio-common/vfprintf.c
> 
>      ditto?
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/stdio-common/vfscanf.c
> 
>      ditto??  i can't tell what's the deal.  where all these changes
>      part of the dpatch or ?
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/sunrpc/rpc_thread.c
> 
>      definitely part of the added dpatch.  defi-maybe?
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/sunrpc/svc.c
> 
>      looks good
> 
> linux/src/glibc-2.3.6.ds1/glibc-2.3.6/sysdeps/unix/sysv/linux/not-cancel.h
> 
>      looks good
> 
