AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AC74C9169@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 19 Mar 2009 15:08:11 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Rendell Fong <rendell.fong@onstor.com>
Subject: Re: please review - change 32139
Message-ID: <20090319150811.7012c5b3@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AC74C9169@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB52AC74C9169@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 19 Mar 2009 12:58:13 -0700 Rendell Fong
<rendell.fong@onstor.com> wrote:

> Change 32139 by rendellf@rendellf-test on 2009/03/19 12:56:15
> *pending*
> 
>         TED26011: can't load kernel from second CF card (sdb1)
> 
>         Fixed disk controller register memory window address mapping
> for second card (socket B) to allow successive file loading from
> either CF card.
> 
>         Fixed device partition string check used for detecting when
> partition is already initialized.
> 
>         Fixed cleanup of socket (memory window unmapping and socket
> power down) when a probe of CF card fails.
> 
>         Changed eee memory mgmt routine definitions to make
> ext2fs_get_mem() and ext2fs_free_mem() work as intended.
> 
> Affected files ...
> 
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/alloc.c#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/badblocks.c#2 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/bitmaps.c#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/block.c#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/bmap.c#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/closefs.c#3 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/dir_iterate.c#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/dosio.c#3 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/dosio.h#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/ext2fs.c#4 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/ext2fs.h#2 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/fileio.c#2 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/freefs.c#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/inode.c#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/namei.c#1 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/openfs.c#3 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/pcmcia.c#5 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/pcmciavar.h#3 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/pmondisk.c#2 edit
> ... //depot/dev/prom/cg/code/sm-pmonext2fs/rw_bitmaps.c#2 edit



= Change 32139 by rendellf@rendellf-test on 2009/03/19 12:56:15
*pending* = 
= 	TED26011: can't load kernel from second CF card (sdb1)
= 	
= 	Fixed disk controller register memory window address mapping
for second = 	card (socket B) to allow successive file loading
from either CF card. = 	
= 	Fixed device partition string check used for detecting when
partition is = 	already initialized.
= 	
= 	Changed eee memory mgmt routine definitions to make
ext2fs_get_mem() and = 	ext2fs_free_mem() work as intended.
= 

prom/cg/code/sm-pmonext2fs/alloc.c

     line 115,142 probably best to just declare buf to be of type void*,
     and then only have to put a single (char *) cast on line 118.

prom/cg/code/sm-pmonext2fs/badblocks.c

     lines 24-33, are you putting in these casts to eliminate warnings,
     or is it somehow producing bad code?

     line 104, ok this is something weird.  if this "FUNCT" isn't
     implemented, then why not just comment out the whole FUNCT?
     there's something FUNCTy about this whole nonsense here that I
     don't get.

     again, what are the casts doing for you?

prom/cg/code/sm-pmonext2fs/bitmaps.c

     casts are good.  probably.  i just don't know why.

prom/cg/code/sm-pmonext2fs/block.c

     Beavis says: you put in a cast.  Heh.

prom/cg/code/sm-pmonext2fs/bmap.c

     ditto

prom/cg/code/sm-pmonext2fs/closefs.c

     dd

prom/cg/code/sm-pmonext2fs/dir_iterate.c

     dd

prom/cg/code/sm-pmonext2fs/dosio.c

     line 238-269ish, i don't get these changes at all, let's talk
     about them.

     line 407-434, same goes here

prom/cg/code/sm-pmonext2fs/dosio.h

     line 24, why 2?  hey, even original DOS can handle 4.

prom/cg/code/sm-pmonext2fs/ext2fs.c

     line 224, there's too much debugging style output right now in
     the prom, let's comment this line out.

     line 335, same deal.  we don't care if file close fails.
     we're only reading.

prom/cg/code/sm-pmonext2fs/ext2fs.h

     omg

     that's all i have to say.

     can we go through all this cruft?  i'd like to understand what
     you've learned here.

prom/cg/code/sm-pmonext2fs/fileio.c

     uhhh

prom/cg/code/sm-pmonext2fs/freefs.c

     er, let's do something so we don't have to edit 500 places where
     ext2fs_get_mem is called...

prom/cg/code/sm-pmonext2fs/inode.c

     ditto

prom/cg/code/sm-pmonext2fs/namei.c

     ditto

prom/cg/code/sm-pmonext2fs/openfs.c

     ditto

prom/cg/code/sm-pmonext2fs/pcmcia.c

     excellent

     old line 2007: say whaaaaat?  that actually compiled?

     line 1970: panic?  what does panic do in a PROM?

     line 2036, shouldn't you return here?  or something to avoid
     possible bad dereferences later?

     would it be the end of the world to just delete all these #if
     0 blocks?

prom/cg/code/sm-pmonext2fs/pcmciavar.h

     looks good

prom/cg/code/sm-pmonext2fs/pmondisk.c

     line 31/32 ok.  phew.  i'm glad you swapped these two.  I'll sleep
     well tonight.


prom/cg/code/sm-pmonext2fs/rw_bitmaps.c

     ditto like the others


