AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AC8B56A31@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 24 Mar 2009 17:59:26 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ed Kwan <ed.kwan@onstor.com>
Subject: Re: please review code change for TED 26523 Polcom 11914 - nfs
 share modify Error: Duplicate option string (anon_uid33)
Message-ID: <20090324175926.783b7f16@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AC8B56A31@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB52AC8B56A31@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 23 Mar 2009 16:04:57 -0700 Ed Kwan <ed.kwan@onstor.com> wrote:

> Change 32159 by edk@edk-dev on 2009/03/23 16:03:58 *pending*
> 
>         For TED 26523 Polcom 11914 - nfs share modify Error: Duplicate
>         option string (anon_uid33)
>         For the anon_uid and anon_gid options, we were printing one
> client per line.  Modified cmd_modifyNdsOptions() to print all the
> clients in the same line.
>         Reviewed by AndyS.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_nfs.c#22 edit


= Change 32159 by edk@edk-dev on 2009/03/23 16:03:58 *pending*
= 
= 	For TED 26523 Polcom 11914 - nfs share modify Error: Duplicate 
= 	option string (anon_uid33)
= 	For the anon_uid and anon_gid options, we were printing one client
= 	per line.  Modified cmd_modifyNdsOptions() to print all the clients
= 	in the same line.
= 	Reviewed by AndyS.
= 

nfx-tree/code/ssc-nfxsh/cmd_nfs.c

     oops, forgot about this one.

     Can you give me a sample output from each?  I'm not entirely sure
     I can picture it in my mind.  I guess my one thought is, what if
     there are 2k clients?  Might be kind of ugly all on one line.
     Of course, might be kind of ugly the other way as well.  So,
     nevermind, no sample necessary, I leave it to you.

     line 2718, this identifier should not be split up into separate
     lines.  either write the code such that these huge identifiers
     can be dispensed with, or have it all on one line.  I'm even
     surprised the compiler takes it.  you can split the line after the
     '=' sign if that helps.  uid =\n mega.silly.identifier[nuts].foo;

     line 2733 too.

     optional: clean up the coding style here.  line 2730 for example,
     	}
        else
        if () {
     should be
     	} else if () {
     like it is elsewhere in the file.  line 2748 too.


     the logic of the code is a bit difficult to follow.  I assume
     that you've tested this, however, for some number of clients > 1?



