AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070410180937.11b33da4@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221571B@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 10 Apr 2007 18:10:00 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review
Message-ID: <20070410181000.18588046@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221571B@onstor-exch02.onstor.net>
References: <20070410134047.364be2b3@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0221571B@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 10 Apr 2007 16:13:18 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> On line 1128 and 1232 you are calling =EF=BB=BFu_mount_secondary() with
> verbose hard coded to 1. Shouldn't this be a macro value defined by a
> debug flag? Was your intention to always have verbose on? Maybe it
> should only be on for a debug build? But then again in production if
> a mount failed it would do so silently.

OK, I think I found and fixed all these.

> Did you want to handle the case where u_mount_secondary is called and
> there is nothing for it to unmount (called twice,) or the case where
> the fstab passed in doesn't match the flash layout? I think this is
> bug # 18506.

Ditto.

> That's all the comments I have.

Check the changelist again.  I have added those extra changes, plus a
couple of changes to verify_install.sh to quiet it down just a touch.
Let me know.

Thanks,

a

> Larry
>=20
> -----Original Message-----
> From: Andy Sharp=20
> Sent: Tuesday, April 10, 2007 1:41 PM
> To: Larry Scheer
> Subject: please review
>=20
> Change 23481 by andys@ripper on 2007/04/09 16:35:16 *pending*
>=20
>         Fix segfault when trying to check software version on
> secondary flash and secondary flash is swonky.
>        =20
>         Fix related errors of other commands like "system config copy"
>         that don't work if there is a swonky secondary flash card.
>        =20
>         Fix excess spewage from "system version -s" command.
>        =20
>         TED00018372 seg fault when "system version -s"
>         TED00018410 cannot system copy init / system copy all [-i]
> after No bug for excess spewage.
>        =20
>         swonky, n.: /etc/fstab file has device names hosed.
>        =20
>         Reviewed by .
>=20
>=20
> Affected files ...
>=20
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#6 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#12 edit
>=20
>=20
>=20
> fixes for:
>=20
>     TED00018372 seg fault when "system version -s"
>     TED00018410 cannot system copy init / system copy all [-i] after
