AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070411115854.4f39dbef@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 11 Apr 2007 11:59:20 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: please review (fix for TED00018533)
Message-ID: <20070411115920.77807105@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Larry,

Please review the fix for 

TED00018533 - check for minimum CF size in "system copy init" is broken

The change is to cmd_flash.c only, and the diff is:

==== //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#7 - /homes/andys/src/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c ====
@@ -137,14 +137,12 @@
 static int
 disk_name(size_t disk_blocks, size_t block_size, char *dtab_name)
 {
-    uint64_t dsize;
        int ret_val;
 #define CF_SIZE_MIN (490 * 2048)  /* 512MB flash with a few blocks missing */
 
-    dsize = disk_blocks * block_size;
        sprintf(dtab_name, "cf%d.label", disk_blocks / 2048); /* MiB */
        printf("Secondary CF card is %d MiB\n", disk_blocks / 2048);
-       if (dsize > CF_SIZE_MIN) {
+       if (disk_blocks > CF_SIZE_MIN) {
                char fullname[128];
                FILE *dtf;
