AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070412164822.3181788c@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E02215726@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 12 Apr 2007 17:05:12 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Request for code review
Message-ID: <20070412170512.2ce74e2e@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02215726@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E02215726@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 12 Apr 2007 15:19:43 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Andy,
>     With these changes we can upgrade a flash that has the new flash
> layout created with system copy init.
> If the plan of coming up with a mandatory maintenance release is still
> valid, these changes can be merged with 2.2.2 to produce a 2.2.3
> release that will allow a successful upgrade to 2.3 with the new
> flash layout.
> 
> These changes passed the unit test. I merged these changes with your
> changes into a LAMBO branch and used that build to upgrade to 2.3.
> 
> Here is the changelist:
> 
> Change 23535 by larrys@larrys-r14-dmip on 2007/04/12 14:09:08
> *pending*
> 
>         Changes to allow upgrade to work on an initialized flash.
>         (Initialized with system copy init.) Changes made to allow
>         these files to be merged with 2.2.2.x to become 2.2.3
> maintenance
>         release which will (could?) become manditory upgrade path
>         from 1.3.3.x to 2.3. (Addresses TED00018387 if 2.2.3 is a
> manditory
>         upgrade and these files and others are merged with 2.2.2 code
> base.)

These changes need to go in after my current work, because some of
these changes will be obviated.  That's if these changes go in at all
[decision made by mgmt]. In other words, these changes need to go in on
top of the changes I'm currently piling up by the truck load.

>         Fix for TED00018543. /bin/[ and /bin/test not being installed.
>         Reviewd by:

Please split these changes out into a separate changelist, they need
to go in before my current work.  I'll have to do a merge or whatever.

> Affected files ...
> 
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#13 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/verify_install.sh#10
> edit
> 
> The files can be found on linux-compile located here:
> 
> /home/larrys/perforce/trees/FB-DELOREAN/nfx-tree/code/ssc-nfxsh
> 
> Thanks,
> 
> Larry
