AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AC9100926@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 23 Apr 2009 08:51:29 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ed Kwan <ed.kwan@onstor.com>
Subject: Re: please review code change for webui issues TED 26695 and 26674
Message-ID: <20090423085129.73466079@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AC9100926@exch1.onstor.net>
References: <2779531E7C760D4491C96305019FEEB52AC9100926@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit


= Change 32293 by edk@edk-r402rel on 2009/04/23 00:12:42 *pending*
=
=	For TED 26695 [Mariner-12257]--webUI slowness and display of phantom vsvr
=	and TED 26674 Web UI (NCM) shows a false vsvr thats named after the diag CLI prompt.
=	Print the RMC session messages to elog instead of stdout.
=

nfx-tree/code/sm-sct/sscccc_ncm.c

     looks good





On Thu, 23 Apr 2009 00:17:40 -0700 Ed Kwan <ed.kwan@onstor.com> wrote:

> This change is not applicable to the dev branch because of some major RMC related changes already made by Max.
> 
> 
> [edk@edk-linux sm-sct]$ p4 describe 32293
> Change 32293 by edk@edk-r402rel on 2009/04/23 00:12:42 *pending*
> 
>         For TED 26695 [Mariner-12257]--webUI slowness and display of phantom vsvr
>         and TED 26674 Web UI (NCM) shows a false vsvr thats named after the diag CLI prompt.
>         Print the RMC session messages to elog instead of stdout.
> 
> Affected files ...
> 
> ... //depot/r402rel/nfx-tree/code/sm-sct/sscccc_ncm.c#1 edit
> 
> 
> [edk@edk-linux sm-sct]$ p4 info
> User name: edk
> Client name: edk-r402rel
> Client host: edk-linux.onstor.net
> Client root: /homes/edk/p4/r402rel
> Current directory: /homes/edk/p4/r402rel/nfx-tree/code/sm-sct
> Client address: 10.0.0.137:36724
> Server address: liszt.onstor.net:1717
> Server root: /p4data/p4root
> Server date: 2009/04/23 00:13:53 -0700 PDT
> Server version: P4D/LINUX26X86_64/2007.2/122958 (2007/05/23)
> Server license: ONStor 40 users (support ends 2009/05/20)
> 
> 
> [edk@edk-linux sm-sct]$ p4 diff -dc ...
> ==== //depot/r402rel/nfx-tree/code/sm-sct/sscccc_ncm.c#1 - /homes/edk/p4/r402rel/nfx-tree/code/sm-sct/sscccc_ncm.c ====
> ***************
> *** 203,209 ****
>       if (!(session = (rmc_session_t *)calloc(sizeof(rmc_session_t),1)))
>           return NULL;
>       else {
> !         printf("New session\n");
>           return session;
>       }
>   }
> --- 203,209 ----
>       if (!(session = (rmc_session_t *)calloc(sizeof(rmc_session_t),1)))
>           return NULL;
>       else {
> !         SN_INFO(("%s: New session\n", __FUNCTION__));
>           return session;
>       }
>   }
> ***************
> *** 221,227 ****
>   static int ncm_closeAcptSess(rmc_session_t *session)
>   {
>       if (RMC_FREE_SESS(session)) {
> !         printf("Freeing session\n");
>           free(session);
>       }
>       return RMC_SUCCESS;
> --- 221,227 ----
>   static int ncm_closeAcptSess(rmc_session_t *session)
>   {
>       if (RMC_FREE_SESS(session)) {
> !         SN_INFO(("%s: Freeing session\n", __FUNCTION__));
>           free(session);
>       }
>       return RMC_SUCCESS;
> 
