AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070413140546.481230fd@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0221572F@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 13 Apr 2007 14:07:18 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review
Message-ID: <20070413140718.06f00176@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0221572F@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0221572C@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0221572F@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

The file /onstor/conf/.fresh-flash only exists in the new format, for
obvious reasons.  I fixed the comment and changed the 'else' to an
'else if'.  Check it out and let me know if the comment is more helpful
now.  Also, did you have any comments on the new flash_install.sh shell
script?  There must be _something_ in there I f#@ked up.

Cheers and thanks,

a


On Fri, 13 Apr 2007 13:51:00 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> In cmd_flash.c the comment on line 1133 and 1134 regarding "the turd
> is toast" won't make sense to anybody but me and you. It was also
> confusing. I don't understand why old versus new layout is mentioned
> in the comment. If any files are copied to the secondary flash,
> regardless of flash layout the cookie/turd should go away, correct?
> We only want it to be there when the flash is newly initialized and
> no files copied. Shouldn't the delete be independent of format? 
> 
> The rest looks ok to me.
> 
> L.
> 
> 
> -----Original Message-----
> From: Larry Scheer 
> Sent: Friday, April 13, 2007 10:58 AM
> To: Andy Sharp
> Cc: Larry Scheer
> Subject: RE: please review
> 
> Just starting to look at this....
> I have one question about the change to openbsd/src/etc/Makefile.
> What happened to mdrive_install.sh? Is it deprecated? Was its
> functionality moved to src/etc/rc. (I have looked at the two files
> yet.) I just want to make sure this wasn't an unintentional delete.
> 
> L.
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, April 12, 2007 11:20 PM
> To: Larry Scheer
> Subject: please review
> 
> change 23496 client ripper
> 
> 
> let me know if you have any questions
> 
> i included the code to refuse to upgrade to secondary flash w/ old
> layout
> 
> there is another new file, openbsd/src/etc/mdrive_fstab that will be
> added after this changelist is committed.  it currently sits in that
> directory under the name new_mdrive_fstab.  it may also be there under
> it's real name but that's just so that 'make release' will work right
> so i could test it.
> 
> 
> Change 23496 by andys@ripper on 2007/04/10 18:25:58 *pending*
> 
>         New flash_install.sh script and friends to support new CF
> layout.
>         
>         TED00018269 need to change master install scripts for new CF
> layout
> 
> Affected files ...
> 
> ... //depot/FB-DELOREAN/nfx-tree/Makefile#7 edit
> ... //depot/FB-DELOREAN/nfx-tree/Tools/flash_install.sh#1 add
> ... //depot/FB-DELOREAN/nfx-tree/Tools/flash_install_512.sh#1 delete
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_flash.c#9 edit
> ... //depot/FB-DELOREAN/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#14 edit
> ... //depot/FB-DELOREAN/openbsd/src/etc/Makefile#1 edit
> ... //depot/FB-DELOREAN/openbsd/src/etc/mdrive_fstab#1 delete
> ... //depot/FB-DELOREAN/openbsd/src/etc/old_mdrive_fstab#1 add
> ... //depot/FB-DELOREAN/openbsd/src/etc/rc#2 edit
