AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>,<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@exch1.onstor.net/INBOX	0	2779531E7C760D4491C96305019FEEB52AC91E47E7@exch1.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 28 Apr 2009 16:49:42 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ed Kwan <ed.kwan@onstor.com>
Cc: Rendell Fong <rendell.fong@onstor.com>
Subject: Re: PERFORCE change 32328 for review
Message-ID: <20090428164942.0d014250@ripper.onstor.net>
In-Reply-To: <2779531E7C760D4491C96305019FEEB52AC91E47E7@exch1.onstor.net>
References: <WEBMAILKuX9aj9k9EWW00032e3f@mail.onstor.com>
	<20090428164342.2ec95c74@ripper.onstor.net>
	<2779531E7C760D4491C96305019FEEB52AC91E47E7@exch1.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 28 Apr 2009 16:47:11 -0700 Ed Kwan <ed.kwan@onstor.com> wrote:

> WebUI should be parsing the CLI output for specific tokens like "System
> temperature" instead of counting lines.  But how many failed/aborted
> WebUI projects do we have in the last 3 years!?

WTF, did you say it's counting lines? <Thud>

That's the sound of my head hitting the desk.

I don't have enough toes to count that high.

> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, April 28, 2009 4:44 PM
> To: Ed Kwan
> Cc: Rendell Fong
> Subject: Re: PERFORCE change 32328 for review
> 
> On Tue, 28 Apr 2009 16:20:01 -0700 Ed Kwan <ed.kwan@onstor.com> wrote:
> 
> > Change 32328 by edk@edk-dev on 2009/04/28 16:15:38
> > 
> > 	For TED 26738 NCM: Model and version fields are empty in Summary page of a gateway
> > 	Removed an extra blank line that was added by change 31382, which confuses WebUI.
> > 	Reviewed by RendellF.
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/code/sm-chassis/chassis-ui.c#28 edit
> > 
> > 
> > http://liszt:1818/@md=d&cd=//depot/$c=G35@/32328?ac=10
> 
> 
> Maybe what we should have done is fix the damn code that falls over
> like a dead fish just because of a single lousy blank line.  Word.
