AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20090504120523.6479631c@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:mail.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILP0SXxKjI7Krd000401bd@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 4 May 2009 12:06:04 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Maxim Kozlovsky <maxim.kozlovsky@onstor.com>
Subject: Re: PERFORCE change 32342 for review
Message-ID: <20090504120604.685ae225@ripper.onstor.net>
In-Reply-To: <WEBMAILP0SXxKjI7Krd000401bd@mail.onstor.com>
References: <WEBMAILP0SXxKjI7Krd000401bd@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 4 May 2009 10:25:01 -0700 Maxim Kozlovsky
<maxim.kozlovsky@onstor.com> wrote:

> Change 32342 by maximk@maximk-5 on 2009/05/04 10:24:47
> 
> 	fix possible duplicate free in case we go through the loop
> twice. Reviewed by jong.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-fs/fs-buf.c#93 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/32342?ac=10

Question:  Should there be a

pageArrayMalloc = NULL;

after

fs_ramDealloc(FS_RAM_CORE_MISC, pageArrayMalloc);

on line 6161?

I obviously don't know this code, but I was curious nonetheless.

